-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pricing vendor and client #5017
Conversation
b22b64b
to
15d4fd2
Compare
aws/provider.go
Outdated
@@ -835,6 +835,7 @@ func providerConfigure(d *schema.ResourceData) (interface{}, error) { | |||
config.KinesisEndpoint = endpoints["kinesis"].(string) | |||
config.KmsEndpoint = endpoints["kms"].(string) | |||
config.LambdaEndpoint = endpoints["lambda"].(string) | |||
config.PricingEndpoint = endpoints["pricing"].(string) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4fbd3c3
to
cedf1fc
Compare
Oops, sorry about that. I actually just removed the custom endpoint option since the API just refused calls from a provider with region other than the endpoint's region and I don't see much use in anyone implementing their own pricing API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @julienduchesne! 🚀
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Will be used for #5009
Changes proposed in this pull request: