Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_route_tables data source filtering #5035

Merged
merged 2 commits into from
Jun 29, 2018

Conversation

duboisf
Copy link
Contributor

@duboisf duboisf commented Jun 29, 2018

Change proposed in this pull request:

Add a filter argument to the aws_route_tables data source.

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsRouteTables'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccDataSourceAwsRouteTables -timeout 120m
=== RUN   TestAccDataSourceAwsRouteTables
--- PASS: TestAccDataSourceAwsRouteTables (36.45s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       36.467s

@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Jun 29, 2018
@bflad bflad added service/ec2 Issues and PRs that pertain to the ec2 service. enhancement Requests to existing resources that expand the functionality or scope. labels Jun 29, 2018
@bflad bflad added this to the v1.26.0 milestone Jun 29, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @duboisf -- thanks! 🚀

1 test passed (all tests)
=== RUN   TestAccDataSourceAwsRouteTables
--- PASS: TestAccDataSourceAwsRouteTables (15.36s)

@bflad bflad merged commit 20e767f into hashicorp:master Jun 29, 2018
bflad added a commit that referenced this pull request Jun 29, 2018
@bflad
Copy link
Contributor

bflad commented Jul 4, 2018

This has been released in version 1.26.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants