Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_vpc_ipv4_cidr_block_association: Support resource import #5069

Merged
merged 1 commit into from
Jul 6, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jul 4, 2018

Changes proposed in this pull request:

  • Use DescribeVpcs with cidr-block-association.association-id filter in read function
  • Add Importer to resource schema

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAwsVpcIpv4CidrBlockAssociation_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAwsVpcIpv4CidrBlockAssociation_basic -timeout 120m
=== RUN   TestAccAwsVpcIpv4CidrBlockAssociation_basic
--- PASS: TestAccAwsVpcIpv4CidrBlockAssociation_basic (49.45s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	49.493s

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. labels Jul 4, 2018
@bflad bflad requested a review from a team July 4, 2018 04:42
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Jul 4, 2018
@bflad
Copy link
Contributor Author

bflad commented Jul 5, 2018

@ewbankkit if you have a second to verify this as well, we can get this in 👍

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ewbankkit
Copy link
Contributor

@bflad I’m hands off keyboard for rest of this week so can’t run the acceptance tests but the code changes LGTM.

@bflad bflad added this to the v1.27.0 milestone Jul 6, 2018
@bflad bflad merged commit e88aa98 into master Jul 6, 2018
@bflad bflad deleted the f-aws_vpc_ipv4_cidr_block_association-import branch July 6, 2018 11:57
bflad added a commit that referenced this pull request Jul 6, 2018
@bflad
Copy link
Contributor Author

bflad commented Jul 11, 2018

This has been released in version 1.27.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants