Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_glue_crawler: Prevent error when deleted outside Terraform #5158

Merged
merged 1 commit into from
Jul 12, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jul 11, 2018

Similar fix as #5141 (with aws_glue_catalog_database) but for aws_glue_crawler

Changes proposed in this pull request:

  • Return false with EntityNotFoundException error instead of that error in aws_glue_crawler exists function

Previously:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSGlueCrawler_recreates'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSGlueCrawler_recreates -timeout 120m
=== RUN   TestAccAWSGlueCrawler_recreates
--- FAIL: TestAccAWSGlueCrawler_recreates (38.53s)
	testing.go:518: Step 1 error: Error refreshing: 1 error(s) occurred:

		* aws_glue_crawler.test: 1 error(s) occurred:

		* aws_glue_crawler.test: aws_glue_crawler.test: EntityNotFoundException: Crawler entry with name tf-acc-test-1396396921265002761 does not exist
			status code: 400, request id: f95a1094-852a-11e8-ab6d-47badaefc25f
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	38.579s
make: *** [testacc] Error 1

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSGlueCrawler'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSGlueCrawler -timeout 120m
=== RUN   TestAccAWSGlueCrawler_JdbcTarget
--- PASS: TestAccAWSGlueCrawler_JdbcTarget (38.12s)
=== RUN   TestAccAWSGlueCrawler_JdbcTarget_Exclusions
--- PASS: TestAccAWSGlueCrawler_JdbcTarget_Exclusions (35.12s)
=== RUN   TestAccAWSGlueCrawler_JdbcTarget_Multiple
--- PASS: TestAccAWSGlueCrawler_JdbcTarget_Multiple (48.99s)
=== RUN   TestAccAWSGlueCrawler_S3Target
--- PASS: TestAccAWSGlueCrawler_S3Target (36.02s)
=== RUN   TestAccAWSGlueCrawler_S3Target_Exclusions
--- PASS: TestAccAWSGlueCrawler_S3Target_Exclusions (38.08s)
=== RUN   TestAccAWSGlueCrawler_S3Target_Multiple
--- PASS: TestAccAWSGlueCrawler_S3Target_Multiple (46.00s)
=== RUN   TestAccAWSGlueCrawler_recreates
--- PASS: TestAccAWSGlueCrawler_recreates (30.43s)
=== RUN   TestAccAWSGlueCrawler_Classifiers
--- PASS: TestAccAWSGlueCrawler_Classifiers (46.90s)
=== RUN   TestAccAWSGlueCrawler_Configuration
--- PASS: TestAccAWSGlueCrawler_Configuration (35.69s)
=== RUN   TestAccAWSGlueCrawler_Description
--- PASS: TestAccAWSGlueCrawler_Description (36.54s)
=== RUN   TestAccAWSGlueCrawler_Schedule
--- PASS: TestAccAWSGlueCrawler_Schedule (37.76s)
=== RUN   TestAccAWSGlueCrawler_SchemaChangePolicy
--- PASS: TestAccAWSGlueCrawler_SchemaChangePolicy (37.69s)
=== RUN   TestAccAWSGlueCrawler_TablePrefix
--- PASS: TestAccAWSGlueCrawler_TablePrefix (37.02s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	504.410s

@bflad bflad added bug Addresses a defect in current functionality. service/glue Issues and PRs that pertain to the glue service. labels Jul 11, 2018
@bflad bflad requested a review from a team July 11, 2018 17:39
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Jul 11, 2018
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad added this to the v1.28.0 milestone Jul 12, 2018
@bflad bflad merged commit 87453cc into master Jul 12, 2018
@bflad bflad deleted the b-aws_glue_crawler-entitynotfound branch July 12, 2018 12:17
bflad added a commit that referenced this pull request Jul 12, 2018
@bflad
Copy link
Contributor Author

bflad commented Jul 18, 2018

This has been released in version 1.28.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/glue Issues and PRs that pertain to the glue service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants