Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor: aws-sdk-go@v1.14.26 #5178

Merged
merged 3 commits into from
Jul 13, 2018
Merged

vendor: aws-sdk-go@v1.14.26 #5178

merged 3 commits into from
Jul 13, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jul 13, 2018

References:

Changes proposed in this pull request:

  • govendor fetch github.com/aws/aws-sdk-go/...@v1.14.26

Output from acceptance testing: Handled via daily acceptance testing

@bflad bflad added dependencies Used to indicate dependency changes. provider Pertains to the provider itself, rather than any interaction with AWS. labels Jul 13, 2018
@bflad bflad requested a review from a team July 13, 2018 06:18
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. dependencies Used to indicate dependency changes. labels Jul 13, 2018
tombuildsstuff
tombuildsstuff approved these changes Jul 13, 2018
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad added this to the v1.28.0 milestone Jul 13, 2018
@bflad
Copy link
Contributor Author

bflad commented Jul 13, 2018

Looks like there was an unusual SDK struct renaming included in this, will fix it up before merge.

aws/aws-sdk-go@v1.14.25...v1.14.26#diff-449b2d24bff784ff76dc7c3890552ae6

$ make test
==> Checking that code complies with gofmt requirements...
go test ./... -timeout=30s -parallel=4
# github.com/terraform-providers/terraform-provider-aws/aws
aws/data_source_aws_efs_file_system.go:108:10: undefined: efs.FileSystemDescription
aws/resource_aws_efs_file_system.go:224:10: undefined: efs.FileSystemDescription
# github.com/terraform-providers/terraform-provider-aws/aws
aws/data_source_aws_efs_file_system.go:108:10: undefined: efs.FileSystemDescription
aws/resource_aws_efs_file_system.go:224:10: undefined: efs.FileSystemDescription
aws/resource_aws_efs_file_system_test.go:37:19: undefined: efs.FileSystemDescription
aws/resource_aws_efs_file_system_test.go:48:43: undefined: efs.FileSystemDescription

@ghost ghost added dependencies Used to indicate dependency changes. size/XXL Managed by automation to categorize the size of a PR. labels Jul 13, 2018
@bflad
tests/provider: Adjust mock EC2 metadata URL path to match aws-sdk-go…
f3f6979 
…@v1.14.26 update which added a trailing slash to prevent redirects
@ghost ghost added the dependencies Used to indicate dependency changes. label Jul 13, 2018
@bflad
Copy link
Contributor Author

bflad commented Jul 13, 2018

TravisCI is happy so now we're happy 🚀

@bflad bflad merged commit 28872c3 into master Jul 13, 2018
@bflad bflad deleted the v-aws-sdk-go-v1.14.26 branch July 13, 2018 15:41
@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
dependencies Used to indicate dependency changes. provider Pertains to the provider itself, rather than any interaction with AWS. size/XXL Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.28.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @tombuildsstuff