Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_db_security_group: Use API provided ARN instead of manually created one #5226

Merged
merged 1 commit into from
Jul 26, 2018
Merged

resource/aws_db_security_group: Use API provided ARN instead of manually created one #5226

merged 1 commit into from
Jul 26, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jul 18, 2018

Changes proposed in this pull request:

  • Use API provided ARN instead of manually created one
  • Use isAWSErr() helper
  • Remove extraneous &schema.Schema in attributes
  • Remove direct * dereferences from d.Set() to prevent potential panics

Output from acceptance testing:

2 tests passed (all tests)
=== RUN   TestAccAWSDBSecurityGroup_basic
--- PASS: TestAccAWSDBSecurityGroup_basic (21.24s)
=== RUN   TestAccAWSDBSecurityGroup_importBasic
--- PASS: TestAccAWSDBSecurityGroup_importBasic (22.98s)

@bflad bflad added service/rds Issues and PRs that pertain to the rds service. technical-debt Addresses areas of the codebase that need refactoring or redesign. labels Jul 18, 2018
@bflad bflad requested a review from a team July 18, 2018 00:33
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Jul 18, 2018
catsby
catsby approved these changes Jul 26, 2018
View reviewed changes
Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:thu

@bflad bflad added this to the v1.30.0 milestone Jul 26, 2018
@bflad bflad merged commit 10f0774 into master Jul 26, 2018
@bflad bflad deleted the td-aws_db_security_group-arn branch July 26, 2018 20:13
mburtless added a commit to mburtless/terraform-provider-aws that referenced this pull request Jul 30, 2018
@mburtless
Adds domain and domain-iam-role-name parameters to resource aws_db_in…
2ad8d53 
…stance.

This commit adds the domain related parameters to allow aws_db_instances to
be joined to a Directory Services Active Directory domain.

The original work to add the parameters was merged from mwalkera125 in hashicorp#5226.

Subsequent changes added acceptance tests and documentation for the new
arguments and attributes.

Co-authored-by: Mike Walker <mike.walker@ticketmaster.com>
Co-authored-by: Matthew Burtless <mburtless@threepnet.com>
@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@catsby catsby catsby approved these changes

Assignees
No one assigned
Labels
service/rds Issues and PRs that pertain to the rds service. size/M Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Milestone
v1.30.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @catsby