Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ena_support #5395

Merged
merged 1 commit into from
Aug 2, 2018
Merged

Support ena_support #5395

merged 1 commit into from
Aug 2, 2018

Conversation

nbrownus
Copy link
Contributor

Partially Fixes #206

Changes proposed in this pull request:

  • Exposes ena_support on aws_ami

@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Jul 31, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- just needs the documentation which I'll add in a commit after yours. 🚀

2 tests passed (all tests)
=== RUN   TestAccAWSAMI_basic
--- PASS: TestAccAWSAMI_basic (59.25s)
=== RUN   TestAccAWSAMI_snapshotSize
--- PASS: TestAccAWSAMI_snapshotSize (59.52s)

@@ -569,5 +571,10 @@ func resourceAwsAmiCommonSchema(computed bool) map[string]*schema.Schema {
Computed: true,
ForceNew: true,
},
"ena_support": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI this new argument needs to be documented in website/docs/r/ami.html.markdown as well.

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. labels Aug 2, 2018
@bflad bflad added this to the v1.30.0 milestone Aug 2, 2018
@bflad bflad merged commit bfacfe9 into hashicorp:master Aug 2, 2018
bflad added a commit that referenced this pull request Aug 2, 2018
@bflad
Copy link
Contributor

bflad commented Aug 2, 2018

This has been released in version 1.30.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@rkhozinov
Copy link

rkhozinov commented Aug 2, 2018

Hey, @bflad @nbrownus what about the related change for the aws_ami_copy resource?

aws_ami_copy.encrypted_ami (new resource required)
      id:                                                 "ami-***" => <computed> (forces new resource)
      architecture:                                       "x86_64" => <computed>
      description:                                        "AMI***" => "AMI***"
      ebs_block_device.#:                                 "9" => <computed>
      ena_support:                                        "true" => "false" (forces new resource)
      encrypted:                                          "true" => "true"
      ephemeral_block_device.#:                           "0" => <computed>

@samjgalbraith
Copy link

I think this is causing Terraform to want to replace our AMIs. It states that the state of the current AMI resource has a value ena_enabled = true (even though the flag was never available via Terraform before, it seems to have had true by default) and it wants to replace the AMI to change ena_enabled to false.

@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Enhanced Networking to aws_instance resource.
4 participants