-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ena_support #5395
Support ena_support #5395
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- just needs the documentation which I'll add in a commit after yours. 🚀
2 tests passed (all tests)
=== RUN TestAccAWSAMI_basic
--- PASS: TestAccAWSAMI_basic (59.25s)
=== RUN TestAccAWSAMI_snapshotSize
--- PASS: TestAccAWSAMI_snapshotSize (59.52s)
@@ -569,5 +571,10 @@ func resourceAwsAmiCommonSchema(computed bool) map[string]*schema.Schema { | |||
Computed: true, | |||
ForceNew: true, | |||
}, | |||
"ena_support": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI this new argument needs to be documented in website/docs/r/ami.html.markdown
as well.
This has been released in version 1.30.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
Hey, @bflad @nbrownus what about the related change for the
|
I think this is causing Terraform to want to replace our AMIs. It states that the state of the current AMI resource has a value ena_enabled = true (even though the flag was never available via Terraform before, it seems to have had true by default) and it wants to replace the AMI to change ena_enabled to false. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Partially Fixes #206
Changes proposed in this pull request:
ena_support
onaws_ami