Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_flow_log - adding support for sending to S3 #5509

Merged
merged 1 commit into from
Oct 25, 2018
Merged

aws_flow_log - adding support for sending to S3 #5509

merged 1 commit into from
Oct 25, 2018

Commits on Oct 19, 2018

  1. resource/aws_flow_log: Support S3 logging

    * Add `log_destination` and `log_destination_type` arguments
    * Deprecate `log_group_name` and conflict it with `log_destination`
    * Mark `iam_role_arn` as Optional
    
    ```
    $ make testacc TEST=./aws TESTARGS='-run=TestAccAWSFlowLog_'
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./aws -v -run=TestAccAWSFlowLog_ -timeout 120m
    === RUN   TestAccAWSFlowLog_VPCID
    --- PASS: TestAccAWSFlowLog_VPCID (75.46s)
    === RUN   TestAccAWSFlowLog_SubnetID
    --- PASS: TestAccAWSFlowLog_SubnetID (28.62s)
    === RUN   TestAccAWSFlowLog_LogDestinationType_CloudWatchLogs
    --- PASS: TestAccAWSFlowLog_LogDestinationType_CloudWatchLogs (28.68s)
    === RUN   TestAccAWSFlowLog_LogDestinationType_S3
    --- PASS: TestAccAWSFlowLog_LogDestinationType_S3 (153.81s)
    PASS
    ok  	github.com/terraform-providers/terraform-provider-aws/aws	287.945s
    ```
    bflad authored and ryandeivert committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    f38bf13 View commit details
    Browse the repository at this point in the history