Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_codebuild_project: Add artifacts encryption_disabled attribute. #5678

Merged
merged 4 commits into from
Aug 30, 2018

Conversation

jtaylormayfield
Copy link
Contributor

Fixes #5656

Changes proposed in this pull request:

  • Add an optional boolean attribute to the CodeBuild project resource to control output artifact encryption.

Output from acceptance testing:

# make testacc TEST=./aws TESTARGS='-run=TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled -timeout 120m
=== RUN   TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled
--- PASS: TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled (32.88s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       (cached)

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/codebuild Issues and PRs that pertain to the codebuild service. labels Aug 27, 2018
@bflad bflad added this to the v1.34.0 milestone Aug 30, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jtaylormayfield! 🚀

21 tests passed (all tests)
--- PASS: TestAccAWSCodeBuildProject_basic (24.56s)
--- PASS: TestAccAWSCodeBuildProject_importBasic (24.81s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodeCommit (24.97s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_GitHubEnterprise (25.00s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodePipeline (25.04s)
--- PASS: TestAccAWSCodeBuildProject_BadgeEnabled (25.32s)
--- PASS: TestAccAWSCodeBuildProject_Source_Auth (25.38s)
--- PASS: TestAccAWSCodeBuildProject_WindowsContainer (25.66s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_Bitbucket (25.60s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_S3 (25.59s)
--- PASS: TestAccAWSCodeBuildProject_Source_GitCloneDepth (28.55s)
--- PASS: TestAccAWSCodeBuildProject_Source_InsecureSSL (28.62s)
--- PASS: TestAccAWSCodeBuildProject_Tags (28.84s)
--- PASS: TestAccAWSCodeBuildProject_Description (29.24s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus (29.34s)
--- PASS: TestAccAWSCodeBuildProject_BuildTimeout (29.74s)
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type (30.12s)
--- PASS: TestAccAWSCodeBuildProject_VpcConfig (35.97s)
--- PASS: TestAccAWSCodeBuildProject_Cache (41.78s)
--- PASS: TestAccAWSCodeBuildProject_EncryptionKey (42.44s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled (23.47s)

@bflad bflad merged commit 8563737 into hashicorp:master Aug 30, 2018
bflad added a commit that referenced this pull request Aug 30, 2018
@jtaylormayfield jtaylormayfield deleted the mine/encryption-disabled branch August 30, 2018 19:12
@bflad
Copy link
Contributor

bflad commented Aug 30, 2018

This has been released in version 1.34.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/codebuild Issues and PRs that pertain to the codebuild service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CodeBuild - Project - Artifacts - Add encryptionDisabled configuration option
2 participants