resource/aws_db_instance: Add deletion_protection argument #6011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bflad
added
the
enhancement
ghost
added
size/L
``` --- PASS: TestAccAWSDBInstance_basic (431.32s) --- PASS: TestAccAWSDBInstance_DeletionProtection (452.56s) --- PASS: TestAccAWSDBInstance_SnapshotIdentifier_DeletionProtection (1346.38s) ```
bflad
force-pushed
the
f-aws_db_instance-deletion_protection
branch
from
83388ca
to
6851c6d
Compare
ghost
added
size/L
paultyng
approved these changes
Oct 3, 2018
|
Same comment as #6010 |
|
@ozbillwang long form answer in #6010 (comment) |
|
This has been released in version 1.39.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "aws" {
version = "~> 1.39.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will submit an AWS Support case regarding the unexpected behavior withCreateDBInstanceReadReplica, but that should not hold up this enhancement from review.AWS Support has confirmed the
CreateDBInstanceReadReplicaissue and noted that it will be fixed at some point in the future.Closes #6006
Changes proposed in this pull request:
deletion_protectionargument toaws_db_instanceresourceOutput from acceptance testing: