Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_appsync_datasource: Various enhancements #6139

Merged
merged 1 commit into from
Oct 18, 2018
Merged

resource/aws_appsync_datasource: Various enhancements #6139

merged 1 commit into from
Oct 18, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Oct 12, 2018

Closes #5674

Changes proposed in this pull request:

  • Support resource import
  • Support HTTP type
  • Make region optional for dynamodb_config and elasticsearch_config

Output from acceptance testing:

--- PASS: TestAccAwsAppsyncDatasource_basic (11.88s)
--- PASS: TestAccAwsAppsyncDatasource_Description (48.21s)
--- PASS: TestAccAwsAppsyncDatasource_DynamoDBConfig_Region (121.27s)
--- PASS: TestAccAwsAppsyncDatasource_DynamoDBConfig_UseCallerCredentials (121.21s)
--- PASS: TestAccAwsAppsyncDatasource_ElasticsearchConfig_Region (720.27s)
--- PASS: TestAccAwsAppsyncDatasource_HTTPConfig_Endpoint (18.03s)
--- PASS: TestAccAwsAppsyncDatasource_Type (17.29s)
--- PASS: TestAccAwsAppsyncDatasource_Type_DynamoDB (110.94s)
--- PASS: TestAccAwsAppsyncDatasource_Type_Elasticsearch (773.89s)
--- PASS: TestAccAwsAppsyncDatasource_Type_HTTP (11.83s)
--- PASS: TestAccAwsAppsyncDatasource_Type_Lambda (30.19s)
--- PASS: TestAccAwsAppsyncDatasource_Type_None (11.14s)

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/appsync Issues and PRs that pertain to the appsync service. labels Oct 12, 2018
@bflad bflad requested a review from a team October 12, 2018 18:49
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 12, 2018
@bflad bflad mentioned this pull request Oct 12, 2018
Closed
@bflad bflad force-pushed the f-aws_appsync_datasource-http branch from 54fdd6e to 1a7ba80 Compare October 18, 2018 13:29
@bflad
resource/aws_appsync_datasource: Various enhancements
bdbf42c 
* Support resource import
* Support HTTP type
* Make region optional for dynamodb_config and elasticsearch_config

```
--- PASS: TestAccAwsAppsyncDatasource_basic (11.88s)
--- PASS: TestAccAwsAppsyncDatasource_Description (48.21s)
--- PASS: TestAccAwsAppsyncDatasource_DynamoDBConfig_Region (121.27s)
--- PASS: TestAccAwsAppsyncDatasource_DynamoDBConfig_UseCallerCredentials (121.21s)
--- PASS: TestAccAwsAppsyncDatasource_ElasticsearchConfig_Region (720.27s)
--- PASS: TestAccAwsAppsyncDatasource_HTTPConfig_Endpoint (18.03s)
--- PASS: TestAccAwsAppsyncDatasource_Type (17.29s)
--- PASS: TestAccAwsAppsyncDatasource_Type_DynamoDB (110.94s)
--- PASS: TestAccAwsAppsyncDatasource_Type_Elasticsearch (773.89s)
--- PASS: TestAccAwsAppsyncDatasource_Type_HTTP (11.83s)
--- PASS: TestAccAwsAppsyncDatasource_Type_Lambda (30.19s)
--- PASS: TestAccAwsAppsyncDatasource_Type_None (11.14s)
```
@bflad bflad force-pushed the f-aws_appsync_datasource-http branch from 1a7ba80 to bdbf42c Compare October 18, 2018 13:32
@bflad bflad added this to the v1.41.0 milestone Oct 18, 2018
@bflad
Copy link
Contributor Author

bflad commented Oct 18, 2018

Rebased with master and verified that acceptance testing is still passing as expected, merging!

--- PASS: TestAccAwsAppsyncDatasource_Type_HTTP (12.76s)
--- PASS: TestAccAwsAppsyncDatasource_Type_None (12.78s)
--- PASS: TestAccAwsAppsyncDatasource_basic (13.24s)
--- PASS: TestAccAwsAppsyncDatasource_Type (17.69s)
--- PASS: TestAccAwsAppsyncDatasource_HTTPConfig_Endpoint (18.76s)
--- PASS: TestAccAwsAppsyncDatasource_Type_Lambda (44.46s)
--- PASS: TestAccAwsAppsyncDatasource_Description (49.98s)
--- PASS: TestAccAwsAppsyncDatasource_DynamoDBConfig_UseCallerCredentials (117.75s)
--- PASS: TestAccAwsAppsyncDatasource_Type_DynamoDB (133.10s)
--- PASS: TestAccAwsAppsyncDatasource_DynamoDBConfig_Region (144.73s)
--- PASS: TestAccAwsAppsyncDatasource_Type_Elasticsearch (776.87s)
--- PASS: TestAccAwsAppsyncDatasource_ElasticsearchConfig_Region (793.95s)

@bflad bflad merged commit 7a24219 into master Oct 18, 2018
@bflad bflad deleted the f-aws_appsync_datasource-http branch October 18, 2018 13:46
bflad added a commit that referenced this pull request Oct 18, 2018
@bflad
Update CHANGELOG for #6139
2e8c65a
@bflad
Copy link
Contributor Author

bflad commented Oct 18, 2018

This has been released in version 1.41.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paddycarver paddycarver paddycarver approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/appsync Issues and PRs that pertain to the appsync service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.41.0
Development

Successfully merging this pull request may close these issues.

Add type "HTTP" for resource aws_appsync_datasource
2 participants
@bflad @paddycarver