Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_lb_listener_rule: Add eventualy consistent read after creation #6154

Merged

Conversation

gseyetik
Copy link
Contributor

It is possible that during the creation of a elbv2 listener rule that the immediate read results in the newly created rule being removed from the state as it can not be found.

This adds a standard 1 minute time out for newly created resources.

Similar to #5167 .

Changes proposed in this pull request:

  • Add a 1 minute eventual consistency read on creation of a elbv2 listener rule.

Output from acceptance testing:

None to run.

@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Oct 14, 2018
@bflad bflad added service/elbv2 Issues and PRs that pertain to the elbv2 service. bug Addresses a defect in current functionality. labels Oct 14, 2018
@bflad bflad added this to the v1.41.0 milestone Oct 14, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @gseyetik! 🚀

--- PASS: TestAccAWSLBListenerRule_multipleConditionThrowsError (1.27s)
--- PASS: TestAccAWSLBListenerRule_Action_Order (162.31s)
--- PASS: TestAccAWSLBListenerRule_oidc (189.36s)
--- PASS: TestAccAWSLBListenerRule_updateRulePriority (197.05s)
--- PASS: TestAccAWSLBListenerRule_redirect (201.16s)
--- PASS: TestAccAWSLBListenerRule_cognito (204.57s)
--- PASS: TestAccAWSLBListenerRule_changeListenerRuleArnForcesNew (210.52s)
--- PASS: TestAccAWSLBListenerRule_fixedResponse (214.53s)
--- PASS: TestAccAWSLBListenerRule_priority (234.31s)
--- PASS: TestAccAWSLBListenerRule_basic (265.98s)

@bflad bflad merged commit cbbf778 into hashicorp:master Oct 14, 2018
bflad added a commit that referenced this pull request Oct 14, 2018
@bflad bflad mentioned this pull request Oct 14, 2018
@bflad
Copy link
Contributor

bflad commented Oct 18, 2018

This has been released in version 1.41.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/elbv2 Issues and PRs that pertain to the elbv2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants