Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/resource/aws_cloudfront_distribution: Switch from resource.Test() to resource.ParallelTest() #6169

Closed
wants to merge 1 commit into from

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Oct 16, 2018

Reference: #5874

Canary deployment of resource.ParallelTest(). We'll default to -parallel=20 in the Make target during actual deployment.

Changes proposed in this pull request:

  • tests/resource/aws_cloudfront_distribution: Switch resource.Test() to resource.ParallelTest()

Output from acceptance testing (locally):

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSCloudFrontDistribution_ -parallel=20'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSCloudFrontDistribution_ -parallel=20 -timeout 120m
=== RUN   TestAccAWSCloudFrontDistribution_importBasic
=== PAUSE TestAccAWSCloudFrontDistribution_importBasic
=== RUN   TestAccAWSCloudFrontDistribution_S3Origin
=== PAUSE TestAccAWSCloudFrontDistribution_S3Origin
=== RUN   TestAccAWSCloudFrontDistribution_S3OriginWithTags
=== PAUSE TestAccAWSCloudFrontDistribution_S3OriginWithTags
=== RUN   TestAccAWSCloudFrontDistribution_customOrigin
=== PAUSE TestAccAWSCloudFrontDistribution_customOrigin
=== RUN   TestAccAWSCloudFrontDistribution_multiOrigin
=== PAUSE TestAccAWSCloudFrontDistribution_multiOrigin
=== RUN   TestAccAWSCloudFrontDistribution_orderedCacheBehavior
=== PAUSE TestAccAWSCloudFrontDistribution_orderedCacheBehavior
=== RUN   TestAccAWSCloudFrontDistribution_Origin_EmptyDomainName
=== PAUSE TestAccAWSCloudFrontDistribution_Origin_EmptyDomainName
=== RUN   TestAccAWSCloudFrontDistribution_Origin_EmptyOriginID
=== PAUSE TestAccAWSCloudFrontDistribution_Origin_EmptyOriginID
=== RUN   TestAccAWSCloudFrontDistribution_noOptionalItemsConfig
=== PAUSE TestAccAWSCloudFrontDistribution_noOptionalItemsConfig
=== RUN   TestAccAWSCloudFrontDistribution_HTTP11Config
=== PAUSE TestAccAWSCloudFrontDistribution_HTTP11Config
=== RUN   TestAccAWSCloudFrontDistribution_IsIPV6EnabledConfig
=== PAUSE TestAccAWSCloudFrontDistribution_IsIPV6EnabledConfig
=== RUN   TestAccAWSCloudFrontDistribution_noCustomErrorResponseConfig
=== PAUSE TestAccAWSCloudFrontDistribution_noCustomErrorResponseConfig
=== CONT  TestAccAWSCloudFrontDistribution_importBasic
=== CONT  TestAccAWSCloudFrontDistribution_noCustomErrorResponseConfig
=== CONT  TestAccAWSCloudFrontDistribution_IsIPV6EnabledConfig
=== CONT  TestAccAWSCloudFrontDistribution_Origin_EmptyOriginID
=== CONT  TestAccAWSCloudFrontDistribution_multiOrigin
=== CONT  TestAccAWSCloudFrontDistribution_Origin_EmptyDomainName
=== CONT  TestAccAWSCloudFrontDistribution_HTTP11Config
=== CONT  TestAccAWSCloudFrontDistribution_orderedCacheBehavior
=== CONT  TestAccAWSCloudFrontDistribution_noOptionalItemsConfig
=== CONT  TestAccAWSCloudFrontDistribution_S3OriginWithTags
=== CONT  TestAccAWSCloudFrontDistribution_customOrigin
=== CONT  TestAccAWSCloudFrontDistribution_S3Origin
--- PASS: TestAccAWSCloudFrontDistribution_Origin_EmptyOriginID (1.50s)
--- PASS: TestAccAWSCloudFrontDistribution_Origin_EmptyDomainName (1.51s)
--- PASS: TestAccAWSCloudFrontDistribution_S3Origin (984.84s)
--- PASS: TestAccAWSCloudFrontDistribution_orderedCacheBehavior (984.94s)
--- PASS: TestAccAWSCloudFrontDistribution_importBasic (985.47s)
--- PASS: TestAccAWSCloudFrontDistribution_noOptionalItemsConfig (987.17s)
--- PASS: TestAccAWSCloudFrontDistribution_HTTP11Config (987.19s)
--- PASS: TestAccAWSCloudFrontDistribution_noCustomErrorResponseConfig (992.72s)
--- PASS: TestAccAWSCloudFrontDistribution_IsIPV6EnabledConfig (992.97s)
--- PASS: TestAccAWSCloudFrontDistribution_multiOrigin (995.10s)
--- PASS: TestAccAWSCloudFrontDistribution_customOrigin (1358.05s)
--- PASS: TestAccAWSCloudFrontDistribution_S3OriginWithTags (1358.61s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1360.145s

Output from acceptance testing (TeamCity):

12 tests passed (all tests)
--- PASS: TestAccAWSCloudFrontDistribution_Origin_EmptyDomainName (0.94s)
--- PASS: TestAccAWSCloudFrontDistribution_Origin_EmptyOriginID (1.39s)
--- PASS: TestAccAWSCloudFrontDistribution_HTTP11Config (904.35s)
--- PASS: TestAccAWSCloudFrontDistribution_importBasic (907.59s)
--- PASS: TestAccAWSCloudFrontDistribution_S3OriginWithTags (908.16s)
--- PASS: TestAccAWSCloudFrontDistribution_multiOrigin (909.00s)
--- PASS: TestAccAWSCloudFrontDistribution_customOrigin (909.30s)
--- PASS: TestAccAWSCloudFrontDistribution_S3Origin (910.23s)
--- PASS: TestAccAWSCloudFrontDistribution_noCustomErrorResponseConfig (911.42s)
--- PASS: TestAccAWSCloudFrontDistribution_IsIPV6EnabledConfig (911.87s)
--- PASS: TestAccAWSCloudFrontDistribution_noOptionalItemsConfig (913.44s)
--- PASS: TestAccAWSCloudFrontDistribution_orderedCacheBehavior (913.72s)

…() to resource.ParallelTest()

Canary deployment of `resource.ParallelTest()`. Local testing results (we'll default to `-parallel=20` in the Make target during actual deployment):

```
make testacc TEST=./aws TESTARGS='-run=TestAccAWSCloudFrontDistribution_ -parallel=20'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSCloudFrontDistribution_ -parallel=20 -timeout 120m
=== RUN   TestAccAWSCloudFrontDistribution_importBasic
=== PAUSE TestAccAWSCloudFrontDistribution_importBasic
=== RUN   TestAccAWSCloudFrontDistribution_S3Origin
=== PAUSE TestAccAWSCloudFrontDistribution_S3Origin
=== RUN   TestAccAWSCloudFrontDistribution_S3OriginWithTags
=== PAUSE TestAccAWSCloudFrontDistribution_S3OriginWithTags
=== RUN   TestAccAWSCloudFrontDistribution_customOrigin
=== PAUSE TestAccAWSCloudFrontDistribution_customOrigin
=== RUN   TestAccAWSCloudFrontDistribution_multiOrigin
=== PAUSE TestAccAWSCloudFrontDistribution_multiOrigin
=== RUN   TestAccAWSCloudFrontDistribution_orderedCacheBehavior
=== PAUSE TestAccAWSCloudFrontDistribution_orderedCacheBehavior
=== RUN   TestAccAWSCloudFrontDistribution_Origin_EmptyDomainName
=== PAUSE TestAccAWSCloudFrontDistribution_Origin_EmptyDomainName
=== RUN   TestAccAWSCloudFrontDistribution_Origin_EmptyOriginID
=== PAUSE TestAccAWSCloudFrontDistribution_Origin_EmptyOriginID
=== RUN   TestAccAWSCloudFrontDistribution_noOptionalItemsConfig
=== PAUSE TestAccAWSCloudFrontDistribution_noOptionalItemsConfig
=== RUN   TestAccAWSCloudFrontDistribution_HTTP11Config
=== PAUSE TestAccAWSCloudFrontDistribution_HTTP11Config
=== RUN   TestAccAWSCloudFrontDistribution_IsIPV6EnabledConfig
=== PAUSE TestAccAWSCloudFrontDistribution_IsIPV6EnabledConfig
=== RUN   TestAccAWSCloudFrontDistribution_noCustomErrorResponseConfig
=== PAUSE TestAccAWSCloudFrontDistribution_noCustomErrorResponseConfig
=== CONT  TestAccAWSCloudFrontDistribution_importBasic
=== CONT  TestAccAWSCloudFrontDistribution_noCustomErrorResponseConfig
=== CONT  TestAccAWSCloudFrontDistribution_IsIPV6EnabledConfig
=== CONT  TestAccAWSCloudFrontDistribution_Origin_EmptyOriginID
=== CONT  TestAccAWSCloudFrontDistribution_multiOrigin
=== CONT  TestAccAWSCloudFrontDistribution_Origin_EmptyDomainName
=== CONT  TestAccAWSCloudFrontDistribution_HTTP11Config
=== CONT  TestAccAWSCloudFrontDistribution_orderedCacheBehavior
=== CONT  TestAccAWSCloudFrontDistribution_noOptionalItemsConfig
=== CONT  TestAccAWSCloudFrontDistribution_S3OriginWithTags
=== CONT  TestAccAWSCloudFrontDistribution_customOrigin
=== CONT  TestAccAWSCloudFrontDistribution_S3Origin
--- PASS: TestAccAWSCloudFrontDistribution_Origin_EmptyOriginID (1.50s)
--- PASS: TestAccAWSCloudFrontDistribution_Origin_EmptyDomainName (1.51s)
--- PASS: TestAccAWSCloudFrontDistribution_S3Origin (984.84s)
--- PASS: TestAccAWSCloudFrontDistribution_orderedCacheBehavior (984.94s)
--- PASS: TestAccAWSCloudFrontDistribution_importBasic (985.47s)
--- PASS: TestAccAWSCloudFrontDistribution_noOptionalItemsConfig (987.17s)
--- PASS: TestAccAWSCloudFrontDistribution_HTTP11Config (987.19s)
--- PASS: TestAccAWSCloudFrontDistribution_noCustomErrorResponseConfig (992.72s)
--- PASS: TestAccAWSCloudFrontDistribution_IsIPV6EnabledConfig (992.97s)
--- PASS: TestAccAWSCloudFrontDistribution_multiOrigin (995.10s)
--- PASS: TestAccAWSCloudFrontDistribution_customOrigin (1358.05s)
--- PASS: TestAccAWSCloudFrontDistribution_S3OriginWithTags (1358.61s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1360.145s
```
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/cloudfront Issues and PRs that pertain to the cloudfront service. labels Oct 16, 2018
@bflad bflad requested a review from a team October 16, 2018 15:39
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Oct 16, 2018
@bflad
Copy link
Contributor Author

bflad commented Oct 16, 2018

Superseded by #6174

@bflad bflad closed this Oct 16, 2018
@bflad bflad deleted the t-aws_cloudfront_distribution-paralleltest branch October 16, 2018 20:10
@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/cloudfront Issues and PRs that pertain to the cloudfront service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant