Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_network_acl: Properly handle ICMP code and type with IPv6 ICMP (protocol 58) #6264

Merged
merged 1 commit into from
Oct 30, 2018
Merged

resource/aws_network_acl: Properly handle ICMP code and type with IPv6 ICMP (protocol 58) #6264

merged 1 commit into from
Oct 30, 2018

Commits on Oct 25, 2018

  1. resource/aws_network_acl: Properly handle ICMP code and type with IPv… 

    …6 ICMP (protocol 58)

Previously:

```
--- FAIL: TestAccAWSNetworkAcl_ipv6ICMPRules (12.17s)
    testing.go:538: Step 0 error: Error applying: 1 error occurred:
        	* aws_network_acl.test: 1 error occurred:
        	* aws_network_acl.test: Error creating ingress entry: MissingParameter: The request must contain the parameter icmpTypeCode.type
        	status code: 400, request id: 9551aec6-d3cf-435f-a35d-0d60b8fd2a69
```

Output from acceptance testing:

```
--- PASS: TestAccAWSNetworkAcl_ipv6ICMPRules (17.51s)
```
    @bflad
    bflad committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    9bc3e2b View commit details
    Browse the repository at this point in the history