Add "name_with_path" to iam_role data source and resource

[rehevkor5]

Changes proposed in this pull request:

Add "name_with_path" to iam_role data source and resource

• Provides the "friendly name" plus the path without leading slash,
  which in some cases must be used instead of "id"/friendly name when the
  role has a non-default path (anything but "/").

Output from acceptance testing:

Not run (sorry).

[bflad]

Hi again, @rehevkor5! 👋 Was this intended for any use case beyond the one we just "fixed" with Glue crawlers? I would imagine most, if not all, AWS service calls that accept a IAM role name also accept a IAM role ARN in some fashion for the path problem.

While this is a fairly simple addition, I think we should try to not introduce additional code if it does not have strong use cases. If there are others, we would love to know. Thanks!

[rehevkor5]

@bflad My main concern was the issue with Glue Crawlers. I don't know whether there may be other places in the AWS API which work the same way or not. I assume it's possible to use the built-in functions of the config language to calculate this value manually, so now that Crawler Role ARN works properly & the documentation has been updated I think it's ok. I understand the motivation for omitting something that might not get a lot of use. Feel free to close, thanks for your attention.

[bflad]

If people are actually looking for this, we can certainly reopen and get this merged. Thanks for your understanding!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!