Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_lambda_function: Handle slower code uploads on creation with configurable timeout #6409

Merged
merged 2 commits into from
Nov 9, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Nov 9, 2018

Fixes #4516

Tested by adding a deliberate 2 minute sleep inside the first resource.Retry() function before the CreateFunction call. Prior to this update, slow ZIP file uploads would have no chance of being successful. Now they can have a configurable timeout. This is not a problem on update since we call UpdateFunctionCode outside any resource.Retry()/StateChangeConf context.

Previously:

--- FAIL: TestAccAWSLambdaFunction_basic (104.02s)
    testing.go:538: Step 0 error: Error applying: 1 error occurred:
        	* aws_lambda_function.lambda_function_test: 1 error occurred:
        	* aws_lambda_function.lambda_function_test: Error creating Lambda function: timeout while waiting for state to become 'success' (timeout: 1m0s)

Now:

--- PASS: TestAccAWSLambdaFunction_basic (113.77s)

…with configurable timeout

Tested by adding a deliberate 2 minute sleep inside the first `resource.Retry()` function before the CreateFunction call.

Previously:

```
--- FAIL: TestAccAWSLambdaFunction_basic (104.02s)
    testing.go:538: Step 0 error: Error applying: 1 error occurred:
        	* aws_lambda_function.lambda_function_test: 1 error occurred:
        	* aws_lambda_function.lambda_function_test: Error creating Lambda function: timeout while waiting for state to become 'success' (timeout: 1m0s)
```

Now:

```
--- PASS: TestAccAWSLambdaFunction_basic (113.77s)
```
@bflad bflad added bug Addresses a defect in current functionality. service/lambda Issues and PRs that pertain to the lambda service. labels Nov 9, 2018
@bflad bflad added this to the v1.43.1 milestone Nov 9, 2018
@bflad bflad requested a review from a team November 9, 2018 04:02
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. labels Nov 9, 2018
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad merged commit 87a3d7c into master Nov 9, 2018
@bflad bflad deleted the b-aws_lambda_function-slow-uploads branch November 9, 2018 18:48
bflad added a commit that referenced this pull request Nov 9, 2018
@bflad
Copy link
Contributor Author

bflad commented Nov 9, 2018

This has been released in version 1.43.1 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/lambda Issues and PRs that pertain to the lambda service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lambda create timeout with large files
2 participants