Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copy_tags option to the resource_aws_dlm_lifecycle_policy #6445

Merged
merged 2 commits into from
Nov 13, 2018

Conversation

cgreatbanks
Copy link

Fixes #6442

Changes proposed in this pull request:

  • Add copy_tags option to the resource_aws_dlm_lifecycle_policy

Output from acceptance testing:

$ make test
==> Checking that code complies with gofmt requirements...
go test ./... -timeout=30s -parallel=4
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1.970s

$ make testacc TESTARGS="-run=TestAccAWSDlmLifecyclePolicy_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSDlmLifecyclePolicy_ -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSDlmLifecyclePolicy_Basic
=== PAUSE TestAccAWSDlmLifecyclePolicy_Basic
=== RUN   TestAccAWSDlmLifecyclePolicy_Full
=== PAUSE TestAccAWSDlmLifecyclePolicy_Full
=== CONT  TestAccAWSDlmLifecyclePolicy_Basic
=== CONT  TestAccAWSDlmLifecyclePolicy_Full
--- PASS: TestAccAWSDlmLifecyclePolicy_Basic (23.30s)
--- PASS: TestAccAWSDlmLifecyclePolicy_Full (31.99s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	32.038s
...

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/dlm Issues and PRs that pertain to the dlm service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 13, 2018
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 13, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for submitting this @cgreatbanks! Looking pretty good. Two little things and we should be able to get this in!

aws/resource_aws_dlm_lifecycle_policy_test.go Show resolved Hide resolved
aws/resource_aws_dlm_lifecycle_policy.go Show resolved Hide resolved
@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Nov 13, 2018
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Nov 13, 2018
@cgreatbanks cgreatbanks force-pushed the dlm_copy_tags_option branch 2 times, most recently from e6bd7c0 to c9bb4b7 Compare November 13, 2018 16:05
Update documention to include copy_tag option
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, @cgreatbanks! LGTM 🚀

--- PASS: TestAccAWSDlmLifecyclePolicy_Basic (7.93s)
--- PASS: TestAccAWSDlmLifecyclePolicy_Full (11.25s)

@bflad bflad added this to the v1.44.0 milestone Nov 13, 2018
@bflad bflad merged commit c9a3bee into hashicorp:master Nov 13, 2018
bflad added a commit that referenced this pull request Nov 13, 2018
@bflad
Copy link
Contributor

bflad commented Nov 15, 2018

This has been released in version 1.44.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
@breathingdust breathingdust removed the waiting-response Maintainers are waiting on response from community or contributor. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/dlm Issues and PRs that pertain to the dlm service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: CopyTags option for DLM
3 participants