Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Kinesis Stream Consumer resource and data source #6565

Closed
wants to merge 2 commits into from
Closed

Adds Kinesis Stream Consumer resource and data source #6565

wants to merge 2 commits into from

Conversation

robertstettner
Copy link
Contributor

@robertstettner robertstettner commented Nov 23, 2018 •
edited
Loading

This adds the new feature of AWS Kinesis Stream Consumers, that allow for a dedicated consumer using enhanced fan-out.
https://docs.aws.amazon.com/streams/latest/dev/building-consumers.html

And: https://aws.amazon.com/about-aws/whats-new/2018/11/aws-lambda-supports-kinesis-data-streams-enhanced-fan-out-and-http2/

Changes proposed in this pull request:

  • Adds aws_kinesis_stream_consumer as new resource
  • Adds aws_kinesis_stream_consumer as new data source

Output from acceptance testing (still WIP):

$ make testacc TESTARGS='-run=TestAccKinesisStreamConsumer'

...

@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/kinesis Issues and PRs that pertain to the kinesis service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 23, 2018
@ghost ghost added the provider Pertains to the provider itself, rather than any interaction with AWS. label Nov 23, 2018
@bflad bflad added new-resource Introduces a new resource. new-data-source Introduces a new data source. labels Nov 25, 2018
@coen-hyde
Copy link

@robertstettner is this still in development?

This was referenced Mar 4, 2019
Closed
Closed
@cludden
Copy link

cludden commented Mar 27, 2019

@robertstettner Any update on this?

@muthu-vgh
Copy link

just wondering if there is any movements on this ?

@aeschright aeschright requested a review from a team June 25, 2019 21:37
@robertstettner
Copy link
Contributor Author

Sorry, I don't think I can continue with this feature. If anyone wants to take over, please do so. I'm closing this one.

@muthu-vgh
Copy link

@chris-whittick sad times, lol

@pgilad
Copy link

pgilad commented Aug 12, 2019

@robertstettner Can you please specify what is missing if someone would want to pick this up?

@rockycore rockycore mentioned this pull request Oct 13, 2019
Closed
@rockycore
Copy link
Contributor

I made a new PR for this #10487

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/kinesis Issues and PRs that pertain to the kinesis service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@robertstettner @coen-hyde @cludden @muthu-vgh @pgilad @rockycore @bflad