Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aws_appmesh_route resource #6766

Merged
merged 1 commit into from
Dec 13, 2018
Merged

Add aws_appmesh_route resource #6766

merged 1 commit into from
Dec 13, 2018

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Dec 7, 2018 •
edited
Loading

@ghost ghost added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Dec 7, 2018
@ewbankkit ewbankkit mentioned this pull request Dec 7, 2018
Closed
@bflad bflad added new-resource Introduces a new resource. service/appmesh Issues and PRs that pertain to the appmesh service. labels Dec 7, 2018
@ewbankkit
Copy link
Contributor Author

Rebased after merge of #6764.
Acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAppmesh'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSAppmesh -timeout 120m
=== RUN   TestAccAWSAppmesh
=== RUN   TestAccAWSAppmesh/VirtualNode
=== RUN   TestAccAWSAppmesh/VirtualNode/basic
=== RUN   TestAccAWSAppmesh/VirtualNode/allAttributes
=== RUN   TestAccAWSAppmesh/VirtualRouter
=== RUN   TestAccAWSAppmesh/VirtualRouter/basic
=== RUN   TestAccAWSAppmesh/Mesh
=== RUN   TestAccAWSAppmesh/Mesh/basic
=== RUN   TestAccAWSAppmesh/Route
=== RUN   TestAccAWSAppmesh/Route/basic
=== RUN   TestAccAWSAppmesh/Route/allAttributes
--- PASS: TestAccAWSAppmesh (124.26s)
    --- PASS: TestAccAWSAppmesh/VirtualNode (39.87s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/basic (14.68s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/allAttributes (25.19s)
    --- PASS: TestAccAWSAppmesh/VirtualRouter (25.60s)
        --- PASS: TestAccAWSAppmesh/VirtualRouter/basic (25.60s)
    --- PASS: TestAccAWSAppmesh/Mesh (14.83s)
        --- PASS: TestAccAWSAppmesh/Mesh/basic (14.83s)
    --- PASS: TestAccAWSAppmesh/Route (43.95s)
        --- PASS: TestAccAWSAppmesh/Route/basic (16.81s)
        --- PASS: TestAccAWSAppmesh/Route/allAttributes (27.14s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	124.284s

@ewbankkit ewbankkit changed the title [WIP] Add aws_appmesh_route resource Add aws_appmesh_route resource Dec 7, 2018
@ewbankkit
Copy link
Contributor Author

Removed WIP.

@ewbankkit
Copy link
Contributor Author

@bflad This is now ready for review; Thanks.

bflad
bflad approved these changes Dec 13, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks as usual @ewbankkit! 🚀

--- PASS: TestAccAWSAppmesh (30.33s)
    --- PASS: TestAccAWSAppmesh/VirtualRouter (6.67s)
        --- PASS: TestAccAWSAppmesh/VirtualRouter/basic (6.67s)
    --- PASS: TestAccAWSAppmesh/Mesh (3.64s)
        --- PASS: TestAccAWSAppmesh/Mesh/basic (3.64s)
    --- PASS: TestAccAWSAppmesh/Route (10.32s)
        --- PASS: TestAccAWSAppmesh/Route/allAttributes (6.38s)
        --- PASS: TestAccAWSAppmesh/Route/basic (3.94s)
    --- PASS: TestAccAWSAppmesh/VirtualNode (9.71s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/basic (3.43s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/allAttributes (6.28s)

@bflad bflad added this to the v1.52.0 milestone Dec 13, 2018
@bflad bflad merged commit f58e6f1 into hashicorp:master Dec 13, 2018
bflad added a commit that referenced this pull request Dec 13, 2018
@bflad
Update CHANGELOG for #6766
df461b2
@ewbankkit ewbankkit deleted the add-appmesh-route branch December 13, 2018 15:41
@bflad
Copy link
Contributor

bflad commented Dec 13, 2018

This has been released in version 1.52.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/appmesh Issues and PRs that pertain to the appmesh service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.52.0
Development

Successfully merging this pull request may close these issues.

Feature request: Support AWS App Mesh
2 participants
@ewbankkit @bflad