Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_glue_crawler: add a security_configuration argument #6797

Merged
merged 3 commits into from
Dec 12, 2018
Merged

r/aws_glue_crawler: add a security_configuration argument #6797

merged 3 commits into from
Dec 12, 2018

Conversation

ilya-v-trofimov
Copy link

Fixes #6714

Changes proposed in this pull request:

  • Add new security_configuration argument to aws_glue_crawler resource

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSGlueCrawler_SecurityConfiguration'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSGlueCrawler_SecurityConfiguration -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSGlueCrawler_SecurityConfiguration
=== PAUSE TestAccAWSGlueCrawler_SecurityConfiguration
=== CONT  TestAccAWSGlueCrawler_SecurityConfiguration
--- PASS: TestAccAWSGlueCrawler_SecurityConfiguration (82.61s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	82.661s

...

@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 11, 2018
@ilya-v-trofimov ilya-v-trofimov changed the title r/glue crawler resource to reference a security configuration r/aws_glue_crawler: add a security_configuration argument Dec 11, 2018
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 12, 2018
bflad
bflad approved these changes Dec 12, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ilya-v-trofimov! 🚀

--- PASS: TestAccAWSGlueCrawler_recreates (21.22s)
--- PASS: TestAccAWSGlueCrawler_Role_ARN_NoPath (26.06s)
--- PASS: TestAccAWSGlueCrawler_S3Target_Exclusions (45.66s)
--- PASS: TestAccAWSGlueCrawler_Description (51.50s)
--- PASS: TestAccAWSGlueCrawler_Role_Name_Path (58.72s)
--- PASS: TestAccAWSGlueCrawler_Classifiers (60.52s)
--- PASS: TestAccAWSGlueCrawler_TablePrefix (61.73s)
--- PASS: TestAccAWSGlueCrawler_Schedule (72.14s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget_Multiple (72.85s)
--- PASS: TestAccAWSGlueCrawler_Configuration (77.32s)
--- PASS: TestAccAWSGlueCrawler_S3Target_Multiple (81.12s)
--- PASS: TestAccAWSGlueCrawler_SchemaChangePolicy (85.05s)
--- PASS: TestAccAWSGlueCrawler_S3Target (85.93s)
--- PASS: TestAccAWSGlueCrawler_DynamodbTarget (88.19s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget (96.72s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget_Exclusions (101.14s)
--- PASS: TestAccAWSGlueCrawler_SecurityConfiguration (101.48s)
--- PASS: TestAccAWSGlueCrawler_Role_ARN_Path (124.43s)

@bflad bflad added this to the v1.52.0 milestone Dec 12, 2018
@bflad bflad merged commit 7cf5e30 into hashicorp:master Dec 12, 2018
bflad added a commit that referenced this pull request Dec 12, 2018
@bflad
Update CHANGELOG for #6797
0d4b868
@bflad
Copy link
Contributor

bflad commented Dec 13, 2018

This has been released in version 1.52.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/glue Issues and PRs that pertain to the glue service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.52.0
Development

Successfully merging this pull request may close these issues.

AWS Glue Crawlers Do Not Support SecurityConfiguration
2 participants
@ilya-v-trofimov @bflad