Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DataPipeline Resource Support #6972

Conversation

teraken0509
Copy link
Contributor

@teraken0509 teraken0509 commented Dec 23, 2018

Fixes #1538

Changes proposed in this pull request:

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataPipeline_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSDataPipeline_ -timeout 120m
=== RUN   TestAccAWSDataPipeline_basic
=== PAUSE TestAccAWSDataPipeline_basic
=== RUN   TestAccAWSDataPipeline_copyActivity
=== PAUSE TestAccAWSDataPipeline_copyActivity
=== RUN   TestAccAWSDataPipeline_disappears
=== PAUSE TestAccAWSDataPipeline_disappears
=== CONT  TestAccAWSDataPipeline_basic
=== CONT  TestAccAWSDataPipeline_disappears
=== CONT  TestAccAWSDataPipeline_copyActivity
--- PASS: TestAccAWSDataPipeline_disappears (31.63s)
--- PASS: TestAccAWSDataPipeline_basic (36.01s)
--- PASS: TestAccAWSDataPipeline_copyActivity (37.50s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	37.557s

TODO

  • Add support serveral resources
  • Add documentation

@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 23, 2018
@teraken0509 teraken0509 force-pushed the feature/add-support-datapipeline-resource branch from 2e7ae02 to b50317f Compare December 23, 2018 04:59
@teraken0509 teraken0509 force-pushed the feature/add-support-datapipeline-resource branch from b50317f to 9eeb9d0 Compare December 30, 2018 13:47
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Dec 30, 2018
@teraken0509 teraken0509 force-pushed the feature/add-support-datapipeline-resource branch 2 times, most recently from 682207d to 6eb86bd Compare January 2, 2019 14:43
@teraken0509 teraken0509 changed the title [WIP] Add DataPipeline Resource Support Add DataPipeline Resource Support Jan 2, 2019
@bflad bflad added new-resource Introduces a new resource. service/datapipeline Issues and PRs that pertain to the datapipeline service. labels Jan 8, 2019
@teraken0509 teraken0509 force-pushed the feature/add-support-datapipeline-resource branch from 6eb86bd to 78bfd8b Compare January 10, 2019 18:12
@scraly
Copy link

scraly commented Jan 11, 2019

Do you know when this feature will be released?
Thanks! :-)

@teraken0509 teraken0509 force-pushed the feature/add-support-datapipeline-resource branch from 78bfd8b to ac88ef6 Compare January 17, 2019 02:58
@teraken0509
Copy link
Contributor Author

Rerun test after rebase master

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataPipeline_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSDataPipeline_ -timeout 120m
=== RUN   TestAccAWSDataPipeline_basic
=== PAUSE TestAccAWSDataPipeline_basic
=== RUN   TestAccAWSDataPipeline_copyActivity
=== PAUSE TestAccAWSDataPipeline_copyActivity
=== RUN   TestAccAWSDataPipeline_disappears
=== PAUSE TestAccAWSDataPipeline_disappears
=== CONT  TestAccAWSDataPipeline_basic
=== CONT  TestAccAWSDataPipeline_disappears
=== CONT  TestAccAWSDataPipeline_copyActivity
--- PASS: TestAccAWSDataPipeline_disappears (35.32s)
--- PASS: TestAccAWSDataPipeline_copyActivity (41.50s)
--- PASS: TestAccAWSDataPipeline_basic (41.64s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	41.694s

@noldar
Copy link

noldar commented Feb 13, 2019

Nice work! Hope it will be merged soon!

@Szasza
Copy link
Contributor

Szasza commented Apr 2, 2019

Thank you for the implementation, it is much appreciated.

@bflad do you happen to know when this will be merged?

Thank you in advance for the response.

@Szasza
Copy link
Contributor

Szasza commented Apr 7, 2019

@kterada0509 apparently this now has a merge conflict.

@teraken0509 teraken0509 force-pushed the feature/add-support-datapipeline-resource branch from da79add to 4661b40 Compare April 8, 2019 02:20
@teraken0509
Copy link
Contributor Author

@kterada0509 apparently this now has a merge conflict.

@Szasza Thanks. I rebased master.

@vauchok
Copy link

vauchok commented Apr 8, 2019

Thanks, @kterada0509
hope, it'll be included in the next terraform-aws-provider release. @bflad

@teraken0509 teraken0509 force-pushed the feature/add-support-datapipeline-resource branch from 116a9dd to 7ba49ae Compare April 9, 2019 07:42
@teraken0509 teraken0509 force-pushed the feature/add-support-datapipeline-resource branch from 7ba49ae to 910855f Compare April 18, 2019 18:08
@teraken0509
Copy link
Contributor Author

Rebase master & fix to corresponding to sdk update.

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataPipeline_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSDataPipeline_ -timeout 120m
=== RUN   TestAccAWSDataPipeline_basic
=== PAUSE TestAccAWSDataPipeline_basic
=== RUN   TestAccAWSDataPipeline_copyActivity
=== PAUSE TestAccAWSDataPipeline_copyActivity
=== RUN   TestAccAWSDataPipeline_disappears
=== PAUSE TestAccAWSDataPipeline_disappears
=== CONT  TestAccAWSDataPipeline_basic
=== CONT  TestAccAWSDataPipeline_disappears
=== CONT  TestAccAWSDataPipeline_copyActivity
--- PASS: TestAccAWSDataPipeline_disappears (44.21s)
--- PASS: TestAccAWSDataPipeline_basic (50.54s)
--- PASS: TestAccAWSDataPipeline_copyActivity (74.77s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	74.838s

@Szasza
Copy link
Contributor

Szasza commented May 10, 2019

@bflad do you happen to have any information on when will this get merged?

Thank you in advance for your insight, it is much appreciated.

@kyprifog
Copy link

Ditto, when will this be released? Lack of Terraform support for Data pipelines derailed an initiative I tried to push recently.

@scraly
Copy link

scraly commented May 29, 2019

Any news about the release date? :-)
Thx

@Szasza
Copy link
Contributor

Szasza commented Jun 5, 2019

@bflad now that TF 0.12 is released, could this PR get some attention please?

Thank you in advance for your time.

@teraken0509
Copy link
Contributor Author

This pull request seems to be difficult to merge.
I split pr to #9267 .

@teraken0509 teraken0509 closed this Jul 8, 2019
@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/datapipeline Issues and PRs that pertain to the datapipeline service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support AWS Data Pipeline
7 participants