aws_kms_ciphertext into new resource keeping datasource #6993
Conversation
ghost
added
size/L
|
@gazoakley would you please re-review when you have a chance? |
There was a problem hiding this comment.
Hi @cperilla-rival 👋 Thanks for submitting this. There are a few minor things below, but I will take care of them in a commit after yours during merge so we can get this released this week. 🚀
--- PASS: TestAccResourceAwsKmsCiphertext_basic (38.43s)
--- PASS: TestAccResourceAwsKmsCiphertext_validate (42.08s)
--- PASS: TestAccResourceAwsKmsCiphertext_validate_withContext (40.76s)
|
|
||
| return &schema.Resource{ | ||
| Create: resourceAwsKmsCiphertextCreate, | ||
| Read: resourceAwsKmsCiphertextRead, |
There was a problem hiding this comment.
Nit: I believe we can replace the empty custom functions with schema.Noop 👍
| } | ||
|
|
||
| const testAccResourceAwsKmsCiphertextConfig_basic = ` | ||
| provider "aws" { |
There was a problem hiding this comment.
Nit: Including the provider configurations for most acceptance testing is extraneous
|
|
||
| # Resource: aws_kms_ciphertext | ||
|
|
||
| The KMS ciphertext resource allows you to encrypt plaintext into ciphertext |
There was a problem hiding this comment.
Nit: We should include a cross referencing link to the aws_kms_ciphertext data source and explain the difference between the two.
| is_enabled = true | ||
| } | ||
|
|
||
| data "aws_kms_ciphertext" "foo" { |
There was a problem hiding this comment.
These test configurations should reference the resource not data source.
|
This has been released in version 2.4.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Fixes #960
As a resource, the encryption is performed on create only.
Changing any of the input forces a new resource.
Rework of PR#2568