Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sagemaker notebook instance #7139

Merged
merged 23 commits into from
Jan 16, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
69f3089
[issue-2493] SageMaker Training Job resource
Jan 11, 2018
4f9e248
[issue-2493] SageMaker Training Job resource
Jan 30, 2018
a865552
Merge branch 'master' into feature/sagemaker-vendor-notebook-instance
Mar 21, 2018
069d5b7
Merge branch 'master' into feature/sagemaker-vendor-notebook-instance
ddcprg May 16, 2018
8912065
Merge remote-tracking branch 'origin/master' into feature/sagemaker-v…
Jun 12, 2018
51774eb
[issue-2493] Sidebar section in docs
Jun 13, 2018
e2b8225
Merge branch 'master' into feature/sagemaker-vendor-notebook-instance
ddcprg Nov 1, 2018
5eabd23
Fixed merge conflict
tracypholmes Jan 7, 2019
3d80117
working on review
tracypholmes Jan 7, 2019
b8944fa
more working on review
tracypholmes Jan 8, 2019
64a6842
Merge branch 'sagemaker-notebook-instance' of https://github.com/terr…
mbfrahry Jan 10, 2019
590dbfe
Adding stateChangeConf support
mbfrahry Jan 10, 2019
de3262c
Mostly finished review
tracypholmes Jan 10, 2019
16fd2bf
Fixing delete
mbfrahry Jan 11, 2019
ed7d0bb
Finishing notebook instance refresh
mbfrahry Jan 14, 2019
2c83eb6
Merge branch 'sagemaker-notebook-instance' of https://github.com/terr…
mbfrahry Jan 14, 2019
f3a81fd
final changes
mbfrahry Jan 15, 2019
11c5900
Removing training job
mbfrahry Jan 15, 2019
b77b62a
Merge branch 'master' into sagemaker-notebook-instance
mbfrahry Jan 15, 2019
6edfbbd
Fixing linting issue
mbfrahry Jan 15, 2019
4141e6f
Merge branch 'sagemaker-notebook-instance' of https://github.com/terr…
mbfrahry Jan 15, 2019
ec585ed
Fixing website link
mbfrahry Jan 15, 2019
44642f7
Addressing comments
mbfrahry Jan 15, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions aws/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ import (
"github.com/aws/aws-sdk-go/service/route53"
"github.com/aws/aws-sdk-go/service/s3"
"github.com/aws/aws-sdk-go/service/s3control"
"github.com/aws/aws-sdk-go/service/sagemaker"
"github.com/aws/aws-sdk-go/service/secretsmanager"
"github.com/aws/aws-sdk-go/service/securityhub"
"github.com/aws/aws-sdk-go/service/servicecatalog"
Expand Down Expand Up @@ -203,6 +204,7 @@ type AWSClient struct {
apigateway *apigateway.APIGateway
appautoscalingconn *applicationautoscaling.ApplicationAutoScaling
autoscalingconn *autoscaling.AutoScaling
sagemakerconn *sagemaker.SageMaker
s3conn *s3.S3
s3controlconn *s3control.S3Control
secretsmanagerconn *secretsmanager.SecretsManager
Expand Down Expand Up @@ -579,6 +581,7 @@ func (c *Config) Client() (interface{}, error) {
client.rdsconn = rds.New(awsRdsSess)
client.redshiftconn = redshift.New(sess)
client.resourcegroupsconn = resourcegroups.New(sess)
client.sagemakerconn = sagemaker.New(sess)
client.simpledbconn = simpledb.New(sess)
client.s3conn = s3.New(awsS3Sess)
client.s3controlconn = s3control.New(awsS3ControlSess)
Expand Down
1 change: 1 addition & 0 deletions aws/provider.go
Original file line number Diff line number Diff line change
Expand Up @@ -630,6 +630,7 @@ func Provider() terraform.ResourceProvider {
"aws_s3_bucket_notification": resourceAwsS3BucketNotification(),
"aws_s3_bucket_metric": resourceAwsS3BucketMetric(),
"aws_s3_bucket_inventory": resourceAwsS3BucketInventory(),
"aws_sagemaker_notebook_instance": resourceAwsSagemakerNotebookInstance(),
"aws_security_group": resourceAwsSecurityGroup(),
"aws_network_interface_sg_attachment": resourceAwsNetworkInterfaceSGAttachment(),
"aws_default_security_group": resourceAwsDefaultSecurityGroup(),
Expand Down
Loading