-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add tags for aws mq resources #7193
Feature/add tags for aws mq resources #7193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition, @kterada0509, with one minor thing which will get fixed on merge. Thanks! 🚀
Output from acceptance testing:
--- PASS: TestAccDataSourceAWSMqBroker_basic (1339.84s)
--- PASS: TestAccAWSMqBroker_basic (1006.13s)
--- PASS: TestAccAWSMqBroker_updateUsers (1418.45s)
--- PASS: TestAccAWSMqBroker_updateTags (1462.92s)
--- PASS: TestAccAWSMqBroker_allFieldsDefaultVpc (2044.39s)
--- PASS: TestAccAWSMqBroker_allFieldsCustomVpc (2374.81s)
--- PASS: TestAccAWSMqConfiguration_withData (8.02s)
--- PASS: TestAccAWSMqConfiguration_basic (13.80s)
--- PASS: TestAccAWSMqConfiguration_updateTags (17.49s)
return err | ||
} | ||
|
||
return getTagsMQ(conn, d, aws.StringValue(out.BrokerArn)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resourceAwsMqBrokerRead
is also called by dataSourceAwsmQBrokerRead
, so a schema addition for tags
in the data source is also necessary:
--- FAIL: TestAccDataSourceAWSMqBroker_basic (874.64s)
testing.go:538: Step 0 error: Error applying: 1 error occurred:
* data.aws_mq_broker.by_id: data.aws_mq_broker.by_id: Invalid address to set: []string{"tags"}
This has been released in version 1.57.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Fixes #6740
Changes proposed in this pull request:
Output from acceptance testing: