Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added session_duration to the assume_role config #7335

Closed
wants to merge 1 commit into from
Closed

Added session_duration to the assume_role config #7335

wants to merge 1 commit into from

Conversation

hamstah
Copy link
Contributor

@hamstah hamstah commented Jan 25, 2019

Fixes #7333

Changes proposed in this pull request:

  • Add a session_duration variable in the assume_role configuration block

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAvailabilityZones'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSAvailabilityZones -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSAvailabilityZones_basic
=== PAUSE TestAccAWSAvailabilityZones_basic
=== RUN   TestAccAWSAvailabilityZones_stateFilter
=== PAUSE TestAccAWSAvailabilityZones_stateFilter
=== CONT  TestAccAWSAvailabilityZones_basic
=== CONT  TestAccAWSAvailabilityZones_stateFilter
--- PASS: TestAccAWSAvailabilityZones_stateFilter (23.93s)
--- PASS: TestAccAWSAvailabilityZones_basic (23.99s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	24.014s

@ghost ghost added size/S Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. documentation Introduces or discusses updates to documentation. labels Jan 25, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 25, 2019
@aeschright aeschright requested a review from a team June 25, 2019 22:10
@aeschright aeschright self-assigned this Oct 21, 2019
@aeschright
Copy link
Contributor

Hi @hamstah ! Are you still interested in adding this? The auth code has been split out into a separate package so you would need to submit the PR there: https://github.com/hashicorp/aws-sdk-go-base
After that, documentation could be added to the provider.

@aeschright
Copy link
Contributor

Closing this since I haven't heard back and the next step is to open a PR on the AWS SDK Go Base repo.

@aeschright aeschright closed this Oct 31, 2019
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow setting session duration when assuming a role
3 participants