Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for DynamoDBv2 IoT topic rule action #7469

Merged
merged 3 commits into from
May 12, 2020
Merged

Add support for DynamoDBv2 IoT topic rule action #7469

merged 3 commits into from
May 12, 2020

Conversation

edwardbrowncross
Copy link
Contributor

Fixes #4534

Changes proposed in this pull request:

  • New aws_iot_topic_rule dynamodbv2 object
  • Documentation for the above

Output from acceptance testing:

$ go test ./... -v -parallel 20 -run=TestAccAWSAvailabilityZones -timeout 120m
=== RUN   TestAccAWSAvailabilityZones_basic
=== PAUSE TestAccAWSAvailabilityZones_basic
=== RUN   TestAccAWSAvailabilityZones_stateFilter
=== PAUSE TestAccAWSAvailabilityZones_stateFilter
=== CONT  TestAccAWSAvailabilityZones_basic
=== CONT  TestAccAWSAvailabilityZones_stateFilter
--- PASS: TestAccAWSAvailabilityZones_basic (23.51s)
--- PASS: TestAccAWSAvailabilityZones_stateFilter (24.80s)
PASS
ok      github.com/edwardbrowncross/terraform-provider-aws/aws  25.387s

@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/iot Issues and PRs that pertain to the iot service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Feb 7, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 12, 2019
@joshuarose
Copy link

Is there anything the community can do to move this forward? This would be a highly beneficial feature for us!

@aeschright aeschright requested a review from a team June 25, 2019 22:11
@stack72 stack72 mentioned this pull request Aug 16, 2019
Closed
@mr337
Copy link

mr337 commented Dec 1, 2019

Recently porting from CF to TF and got bit by this. Is there anything else to do to keep this PR moving? Happy to test or help any way I can on my end :)

@MichaelStott
Copy link

MichaelStott commented Feb 3, 2020 •
edited
Loading

Same here, is there anything we can do to get this merged?

@nicofuccella
Copy link

+1

@sylvainv
Copy link

sylvainv commented Mar 11, 2020 •
edited
Loading

Could this PR be merged? Is there anything that is preventing the mege?

@lewchuk
Copy link
Contributor

lewchuk commented Mar 13, 2020

@bflad @gdavison you two seem like you might be active maintainers of this repo, any chance we can get some eyes on this PR?

@bflad bflad self-assigned this Mar 18, 2020
HerrTeuer
HerrTeuer reviewed Mar 25, 2020
View reviewed changes
Copy link

@HerrTeuer HerrTeuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be merged to the repository

@sylvainv
Copy link

Any update on this issue @bflad

@bflad bflad added this to the v2.62.0 milestone May 12, 2020
bflad
bflad reviewed May 12, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @edwardbrowncross 👋 Thank you for working on this and apologies for the delays getting it reviewed. We will be merging #7469, #9859, #9890, and #12714 at the same time to handle all the merge conflicts. 👍

@bflad bflad merged commit 8ed155b into hashicorp:master May 12, 2020
bflad added a commit that referenced this pull request May 12, 2020
@bflad
Update CHANGELOG for #7469, #9859, #9890, and #12714
f6fb08b
@ghost
Copy link

ghost commented May 15, 2020

This has been released in version 2.62.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jun 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad left review comments

@HerrTeuer HerrTeuer HerrTeuer left review comments

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/iot Issues and PRs that pertain to the iot service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.62.0
Development

Successfully merging this pull request may close these issues.

Support for IOT Rule Action "dynamoDBv2"
9 participants
@edwardbrowncross @joshuarose @mr337 @MichaelStott @nicofuccella @sylvainv @lewchuk @bflad @HerrTeuer