-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add partition_count argument to aws_placement_group #7649
add partition_count argument to aws_placement_group #7649
Conversation
Hi @ziggythehamster |
Hello @ziggythehamster ! Could you please review this commit? Thanks. |
Hello, Thanks! |
It looks good to me - I'm already running a fork containing this PR because I desperately needed this feature, but that is of course not great. Hopefully someone at Hashicorp can work this through. You do have some conflicts though. |
AWS added partition placement group feature which uses partition_count argument. So I added partiton_count argument to set the number.
816791f
to
9c09fb8
Compare
Hi @ziggythehamster , @Monpoke , @AlexanderKaraberov , Well, I have rebased latest master and resolve some conflicts.
I'd like @bflad or other Hashicorp members to re-review my new commits. regards, |
I also would like them to review this (and #7777). It's not fun maintaining a fork! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on our experience - have had this working in a forked repo for ~9 months. Would love to get this integrated here!
I'm using the fork in #7777 for some time now (and updated for latest provider release, see: https://github.com/art19/terraform-provider-aws/tree/art19-v2.53.0) without issue. |
There is a newer, merging, almost identical PR in #15360. I'm not sure how to poke Hashicorp to review and merge either of these though :( |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
・Fix #7754
AWS added partition placement group feature which uses partition_count argument, so I added partiton_count argument to set the number.
Changes proposed in this pull request:
Output from acceptance testing:
And bellows are sample partition placement group which acctest has created.