test/resource/aws_api_gateway_usage_plan: Prevent intermittent ConflictException errors for concurrent deployments #7925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctException errors for concurrent deployments
Previously, the test configurations could trigger two deployments at the same time since the ordering was not guaranteed. If we still see issues with this error in the future even with ordering these properly, we can consider allowing retries in the `aws_api_gateway_deployment` resource for this error.
Previous output from acceptance testing:
```
--- FAIL: TestAccAWSAPIGatewayUsagePlan_basic (738.05s)
testing.go:568: Step 0 error: errors during apply:
Error: Error creating API Gateway Deployment: ConflictException: Another Deployment is in progress for rest api with id dy728fw3i3 . Please try again later.
--- FAIL: TestAccAWSAPIGatewayUsagePlan_productCode (59.28s)
testing.go:568: Step 0 error: errors during apply:
Error: Error creating API Gateway Deployment: ConflictException: Another Deployment is in progress for rest api with id uf0qt1c7da . Please try again later.
--- FAIL: TestAccAWSAPIGatewayUsagePlan_throttling (439.70s)
testing.go:568: Step 0 error: errors during apply:
Error: Error creating API Gateway Deployment: ConflictException: Another Deployment is in progress for rest api with id nu0670a339 . Please try again later.
--- FAIL: TestAccAWSAPIGatewayUsagePlan_apiStages (27.48s)
testing.go:568: Step 0 error: errors during apply:
Error: Error creating API Gateway Deployment: ConflictException: Another Deployment is in progress for rest api with id edoilchkxb . Please try again later.
--- FAIL: TestAccAWSAPIGatewayUsagePlan_importBasic (122.32s)
testing.go:568: Step 0 error: errors during apply:
Error: Error creating API Gateway Deployment: ConflictException: Another Deployment is in progress for rest api with id 4t4s36a8a3 . Please try again later.
--- FAIL: TestAccAWSAPIGatewayUsagePlan_quota (375.79s)
testing.go:568: Step 0 error: errors during apply:
Error: Error creating API Gateway Deployment: ConflictException: Another Deployment is in progress for rest api with id 1snamo3rpa . Please try again later.
--- FAIL: TestAccAWSAPIGatewayUsagePlan_throttlingInitialRateLimit (905.32s)
testing.go:568: Step 0 error: errors during apply:
Error: Error creating API Gateway Deployment: ConflictException: Another Deployment is in progress for rest api with id xlnb4foagg . Please try again later.
```
Output from acceptance testing:
```
--- PASS: TestAccAWSAPIGatewayUsagePlan_throttlingInitialRateLimit (68.05s)
--- PASS: TestAccAWSAPIGatewayUsagePlan_apiStages (99.87s)
--- PASS: TestAccAWSAPIGatewayUsagePlan_importBasic (129.23s)
--- PASS: TestAccAWSAPIGatewayUsagePlan_basic (199.02s)
--- PASS: TestAccAWSAPIGatewayUsagePlan_throttling (235.79s)
--- PASS: TestAccAWSAPIGatewayUsagePlan_quota (262.42s)
--- PASS: TestAccAWSAPIGatewayUsagePlan_description (301.14s)
--- PASS: TestAccAWSAPIGatewayUsagePlan_productCode (345.68s)
```
bflad
added
tests
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Previously, the test configurations could trigger two deployments at the same time since the ordering was not guaranteed. If we still see issues with this error in the future even with ordering these properly, we can consider allowing retries in the
aws_api_gateway_deploymentresource for this error.Previous output from acceptance testing:
Output from acceptance testing: