Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R/aws backup selection #8062

Closed

Conversation

devonbleak
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #7166 - should be the last resource required to close

Changes proposed in this pull request:

  • Add resource aws_backup_selection

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAwsBackupSelection'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAwsBackupSelection -timeout 120m
=== RUN   TestAccAwsBackupSelection_basic
=== PAUSE TestAccAwsBackupSelection_basic
=== CONT  TestAccAwsBackupSelection_basic
--- PASS: TestAccAwsBackupSelection_basic (65.25s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       67.521s

Possibly controversial things:

  • API packages almost everything into a single BackupSelection block which I flattened into the main resource.
  • Adopted the IAM condition test/variable/value style for tag_condition so they're consistent, but would be an easy fix to convert to the API's native type/key/value if desired.

@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 24, 2019
@ewbankkit
Copy link
Contributor

See also #7382.

@devonbleak
Copy link
Contributor Author

See also #7382.

@ewbankkit Not sure how I missed that one - taking a look they seem very similar, will close this one.

@devonbleak devonbleak closed this Mar 25, 2019
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for AWS Backup
2 participants