-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Glacier Deep Archive storage class #8109
Add support for Glacier Deep Archive storage class #8109
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, @sunilkumarmohanty! Thanks so much for adding the testing.
--- PASS: TestAccAWSS3BucketObject_storageClass (108.52s)
--- PASS: TestAccAWSS3Bucket_LifecycleExpireMarkerOnly (52.01s)
--- PASS: TestAccAWSS3Bucket_Lifecycle (74.91s)
@@ -903,6 +903,7 @@ func validateS3BucketLifecycleTransitionStorageClass() schema.SchemaValidateFunc | |||
s3.TransitionStorageClassStandardIa, | |||
s3.TransitionStorageClassOnezoneIa, | |||
s3.TransitionStorageClassIntelligentTiering, | |||
s3.StorageClassDeepArchive, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit: Looks like there is an AWS Go SDK constant to match the others in this function: TransitionStorageClassDeepArchive
-- will adjust this on merge so we can release this today.
This has been released in version 2.4.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Fixes #8106
Changes proposed in this pull request:
Output from acceptance testing: