deps: github.com/golangci/golangci-lint/cmd/golangci-lint@v1.16.0

[bflad]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

References:

• https://github.com/golangci/golangci-lint/releases/tag/v1.16.0
• provider: Fix updated govet composites and nilness checks #7993 (comment)

We can try using the GOGC flag to influence garbage collection if necessary.

Updated via:

$ go get github.com/golangci/golangci-lint/cmd/golangci-lint@v1.16.0
$ go mod tidy
$ go mod vendor

[bflad]

RSS from v1.15.0 to v1.16.0 is only a little worse (better than the problematic commit in the middle) so we might be okay to skip tuning GOGC for now. If it has memory trouble in the future we can revisit the customization.

# golangci-lint v1.16.0
5605507072  maximum resident set size
# golangci-lint from commit at time of https://github.com/terraform-providers/terraform-provider-aws/pull/7993#discussion_r270681029
6227824640  maximum resident set size
# golangci-lint v1.15.0
5142007808  maximum resident set size

[bflad]

The above is without enabling staticcheck. Once its enabled, we do need to start looking at tuning GOGC, e.g.

$ time -l ~/go/bin/golangci-lint run ./aws
       26.44 real        89.50 user         8.99 sys
6343839744  maximum resident set size
...

$ GOGC=50 time -l ~/go/bin/golangci-lint run ./aws
       30.10 real       122.25 user         9.22 sys
6118998016  maximum resident set size
...

$ GOGC=30 time -l ~/go/bin/golangci-lint run ./aws
       33.93 real       161.87 user         7.80 sys
5039095808  maximum resident set size

I'm adding a second commit which enables staticcheck and tunes GOGC=30 but we can discuss or remove as necessary.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!