Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add err object to return when err is not nil #8190

Conversation

teraken0509
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

References: #8076 (comment)

Changes proposed in this pull request:

  • Add return err object
    • It help for find out why error occured
      Output from acceptance testing:
$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSCloudWatchEventRule_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSCloudWatchEventRule_ -timeout 120m
=== RUN   TestAccAWSCloudWatchEventRule_importBasic
=== PAUSE TestAccAWSCloudWatchEventRule_importBasic
=== RUN   TestAccAWSCloudWatchEventRule_basic
=== PAUSE TestAccAWSCloudWatchEventRule_basic
=== RUN   TestAccAWSCloudWatchEventRule_prefix
=== PAUSE TestAccAWSCloudWatchEventRule_prefix
=== RUN   TestAccAWSCloudWatchEventRule_tags
=== PAUSE TestAccAWSCloudWatchEventRule_tags
=== RUN   TestAccAWSCloudWatchEventRule_full
=== PAUSE TestAccAWSCloudWatchEventRule_full
=== RUN   TestAccAWSCloudWatchEventRule_enable
=== PAUSE TestAccAWSCloudWatchEventRule_enable
=== CONT  TestAccAWSCloudWatchEventRule_importBasic
=== CONT  TestAccAWSCloudWatchEventRule_full
=== CONT  TestAccAWSCloudWatchEventRule_enable
=== CONT  TestAccAWSCloudWatchEventRule_prefix
=== CONT  TestAccAWSCloudWatchEventRule_tags
=== CONT  TestAccAWSCloudWatchEventRule_basic
--- PASS: TestAccAWSCloudWatchEventRule_prefix (27.46s)
--- PASS: TestAccAWSCloudWatchEventRule_full (29.50s)
--- PASS: TestAccAWSCloudWatchEventRule_importBasic (30.97s)
--- PASS: TestAccAWSCloudWatchEventRule_basic (46.56s)
--- PASS: TestAccAWSCloudWatchEventRule_enable (63.71s)
--- PASS: TestAccAWSCloudWatchEventRule_tags (66.83s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	66.906s

@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Apr 4, 2019
@bflad bflad added service/cloudwatchevents technical-debt Addresses areas of the codebase that need refactoring or redesign. labels Apr 4, 2019
@bflad bflad added this to the v2.5.0 milestone Apr 4, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this @kterada0509 🚀

@bflad bflad merged commit c5c8b5c into hashicorp:master Apr 4, 2019
@teraken0509 teraken0509 deleted the feature/fix-cloudwatchevent-resource-tags-error-handling branch March 5, 2020 14:06
@ghost
Copy link

ghost commented Mar 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XS Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants