Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service/secretsmanager: Handle additional scheduled/marked for deletion error messages #8219

Merged

Commits on Apr 5, 2019

  1. resource/aws_secretsmanager_secret: Handle additional scheduled for d…

    …eletion InvalidRequestException error during immediate recreation
    
    Previous output from acceptance testing:
    
    ```
    --- FAIL: TestAccAwsSecretsManagerSecret_RecoveryWindowInDays_Recreate (6.87s)
        testing.go:538: Step 1 error: Error applying: 1 error occurred:
              * aws_secretsmanager_secret.test: 1 error occurred:
              * aws_secretsmanager_secret.test: error creating Secrets Manager Secret: InvalidRequestException: You can't create this secret because a secret with this name is already scheduled for deletion.
    ```
    
    Output from acceptance testing:
    
    ```
    --- PASS: TestAccAwsSecretsManagerSecret_policy (10.63s)
    --- PASS: TestAccAwsSecretsManagerSecret_Basic (11.18s)
    --- PASS: TestAccAwsSecretsManagerSecret_withNamePrefix (11.23s)
    --- PASS: TestAccAwsSecretsManagerSecret_Description (19.12s)
    --- PASS: TestAccAwsSecretsManagerSecret_Tags (33.62s)
    --- PASS: TestAccAwsSecretsManagerSecret_RecoveryWindowInDays_Recreate (45.49s)
    --- PASS: TestAccAwsSecretsManagerSecret_RotationLambdaARN (46.06s)
    --- PASS: TestAccAwsSecretsManagerSecret_RotationRules (48.05s)
    --- PASS: TestAccAwsSecretsManagerSecret_KmsKeyID (50.75s)
    ```
    bflad committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    cafa62d View commit details
    Browse the repository at this point in the history
  2. tests/resource/aws_secretsmanager_secret_version: Handle additional m…

    …arked for deletion InvalidRequestException error during CheckDestroy
    
    Previous output from acceptance testing:
    
    ```
    --- FAIL: TestAccAwsSecretsManagerSecretVersion_Base64Binary (7.05s)
        testing.go:599: Error destroying resource! WARNING: Dangling resources
            may exist. The full state and error is shown below.
    
            Error: Check failed: InvalidRequestException: You can’t perform this operation on the secret because it was marked for deletion.
    
    --- FAIL: TestAccAwsSecretsManagerSecretVersion_BasicString (6.82s)
        testing.go:599: Error destroying resource! WARNING: Dangling resources
            may exist. The full state and error is shown below.
    
            Error: Check failed: InvalidRequestException: You can’t perform this operation on the secret because it was marked for deletion.
    
    --- FAIL: TestAccAwsSecretsManagerSecretVersion_VersionStages (16.18s)
        testing.go:599: Error destroying resource! WARNING: Dangling resources
            may exist. The full state and error is shown below.
    
            Error: Check failed: InvalidRequestException: You can’t perform this operation on the secret because it was marked for deletion.
    ```
    
    Output from acceptance testing:
    
    ```
    --- PASS: TestAccAwsSecretsManagerSecretVersion_BasicString (11.80s)
    --- PASS: TestAccAwsSecretsManagerSecretVersion_Base64Binary (11.81s)
    --- PASS: TestAccAwsSecretsManagerSecretVersion_VersionStages (25.33s)
    ```
    bflad committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    cfdf4a0 View commit details
    Browse the repository at this point in the history