Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support resource tags for elastic beanstalk resources #8614

Conversation

teraken0509
Copy link
Contributor

@teraken0509 teraken0509 commented May 13, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #7897

Release note for CHANGELOG:

- resource/aws_elastic_beanstalk_application: Add `tags` and `arn` attribute (#7897)
- resource/aws_elastic_beanstalk_application_version: Add `tags` and `arn` attribute (#7897)

Output from acceptance testing:

  • testing for aws_elastic_beanstalk_application resource
$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSBeanstalkApp_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSBeanstalkApp_ -timeout 120m
=== RUN   TestAccAWSBeanstalkApp_basic
=== PAUSE TestAccAWSBeanstalkApp_basic
=== RUN   TestAccAWSBeanstalkApp_appversionlifecycle
=== PAUSE TestAccAWSBeanstalkApp_appversionlifecycle
=== RUN   TestAccAWSBeanstalkApp_tags
=== PAUSE TestAccAWSBeanstalkApp_tags
=== CONT  TestAccAWSBeanstalkApp_basic
=== CONT  TestAccAWSBeanstalkApp_tags
=== CONT  TestAccAWSBeanstalkApp_appversionlifecycle
--- PASS: TestAccAWSBeanstalkApp_basic (32.33s)
--- PASS: TestAccAWSBeanstalkApp_tags (93.11s)
--- PASS: TestAccAWSBeanstalkApp_appversionlifecycle (93.29s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	93.352s
  • testing for aws_elastic_beanstalk_application_version resource
$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSBeanstalkAppVersion_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSBeanstalkAppVersion_ -timeout 120m
=== RUN   TestAccAWSBeanstalkAppVersion_basic
=== PAUSE TestAccAWSBeanstalkAppVersion_basic
=== RUN   TestAccAWSBeanstalkAppVersion_duplicateLabels
=== PAUSE TestAccAWSBeanstalkAppVersion_duplicateLabels
=== RUN   TestAccAWSBeanstalkAppVersion_tags
=== PAUSE TestAccAWSBeanstalkAppVersion_tags
=== CONT  TestAccAWSBeanstalkAppVersion_basic
=== CONT  TestAccAWSBeanstalkAppVersion_tags
=== CONT  TestAccAWSBeanstalkAppVersion_duplicateLabels
--- PASS: TestAccAWSBeanstalkAppVersion_basic (58.87s)
--- PASS: TestAccAWSBeanstalkAppVersion_duplicateLabels (60.02s)
--- PASS: TestAccAWSBeanstalkAppVersion_tags (205.65s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	205.744s

@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels May 13, 2019
@teraken0509 teraken0509 force-pushed the feature/add-support-resource-tags-for-elastic-beanstalk-resources branch from ce577dc to ba7aff6 Compare May 13, 2019 14:03
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label May 16, 2019
@bflad bflad added this to the v2.11.0 milestone May 16, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Output from AWS Standard acceptance testing:

--- PASS: TestAccAWSBeanstalkApp_basic (15.08s)
--- PASS: TestAccAWSBeanstalkAppVersion_basic (37.68s)
--- PASS: TestAccAWSBeanstalkAppVersion_duplicateLabels (38.09s)
--- PASS: TestAccAWSBeanstalkApp_appversionlifecycle (41.77s)
--- PASS: TestAccAWSBeanstalkApp_tags (42.70s)
--- PASS: TestAccAWSBeanstalkAppVersion_tags (134.73s)

Output from AWS GovCloud (US) acceptance testing:

--- PASS: TestAccAWSBeanstalkApp_basic (21.85s)
--- PASS: TestAccAWSBeanstalkAppVersion_basic (61.13s)
--- PASS: TestAccAWSBeanstalkApp_tags (73.14s)
--- PASS: TestAccAWSBeanstalkAppVersion_duplicateLabels (73.27s)
--- PASS: TestAccAWSBeanstalkApp_appversionlifecycle (85.86s)
--- PASS: TestAccAWSBeanstalkAppVersion_tags (166.02s)

@bflad bflad merged commit 95a14a8 into hashicorp:master May 16, 2019
bflad added a commit that referenced this pull request May 16, 2019
@bflad
Copy link
Contributor

bflad commented May 17, 2019

This has been released in version 2.11.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@teraken0509 teraken0509 deleted the feature/add-support-resource-tags-for-elastic-beanstalk-resources branch March 5, 2020 14:05
@ghost
Copy link

ghost commented Mar 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS Elastic Beanstalk resources: Add support for resource tags
2 participants