Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add name, desc for SSM maintenance window targets #8671

Merged
merged 4 commits into from
May 17, 2019
Merged

Add name, desc for SSM maintenance window targets #8671

merged 4 commits into from
May 17, 2019

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #6471

Release note for CHANGELOG:

resource/aws_ssm_maintenance_window_target: Add support for name and
description for maintenance window targets

Output from acceptance testing:

make testacc TESTARGS="-run=TestAccAWSSSMMaintenanceWindowTarget"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSSSMMaintenanceWindowTarget -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSSSMMaintenanceWindowTarget_basic
=== PAUSE TestAccAWSSSMMaintenanceWindowTarget_basic
=== RUN   TestAccAWSSSMMaintenanceWindowTarget_validation
=== PAUSE TestAccAWSSSMMaintenanceWindowTarget_validation
=== RUN   TestAccAWSSSMMaintenanceWindowTarget_update
=== PAUSE TestAccAWSSSMMaintenanceWindowTarget_update
=== CONT  TestAccAWSSSMMaintenanceWindowTarget_basic
=== CONT  TestAccAWSSSMMaintenanceWindowTarget_update
=== CONT  TestAccAWSSSMMaintenanceWindowTarget_validation
--- PASS: TestAccAWSSSMMaintenanceWindowTarget_validation (3.10s)
--- PASS: TestAccAWSSSMMaintenanceWindowTarget_basic (31.51s)
--- PASS: TestAccAWSSSMMaintenanceWindowTarget_update (47.40s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       49.797s
...

nbrys and others added 2 commits May 17, 2019 15:18
@nbrys @ryndaniels
issue-6471
b0288cd 
Add name and description for maintenance window targets
@ryndaniels
Inline validation for maintenance window target name
d429ddc
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/ssm Issues and PRs that pertain to the ssm service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels May 17, 2019
@ryndaniels ryndaniels requested a review from a team May 17, 2019 13:32
@ryndaniels ryndaniels mentioned this pull request May 17, 2019
Closed
nywilken
nywilken reviewed May 17, 2019
View reviewed changes
aws/resource_aws_ssm_maintenance_window_target_test.go Outdated
@@ -160,6 +190,8 @@ resource "aws_ssm_maintenance_window" "foo" {
}

resource "aws_ssm_maintenance_window_target" "target" {
name = "TestMaintenanceWindowTarget"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we have some extra white space here, and in some of the other test configs.

nywilken
nywilken approved these changes May 17, 2019
View reviewed changes
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few formatting nit-picks but otherwise good to go. 👍

@ryndaniels ryndaniels merged commit 31c3c02 into master May 17, 2019
@nywilken nywilken deleted the ryn-nbrys-maintenance-window branch May 23, 2019 01:14
nywilken added a commit that referenced this pull request May 23, 2019
@nywilken
Update CHANGELOG for #8671
5c2f5c4 
Add GitHub PR link placeholder
@bflad bflad added this to the v2.12.0 milestone May 24, 2019
@bflad
Copy link
Contributor

bflad commented May 24, 2019

This has been released in version 2.12.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@mrobinso12 mrobinso12 mentioned this pull request May 28, 2019
Closed
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nywilken nywilken nywilken approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/ssm Issues and PRs that pertain to the ssm service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.12.0
Development

Successfully merging this pull request may close these issues.

Add the name and description fields in terraform when creating SSM Maintenance window targets
4 participants
@ryndaniels @bflad @nywilken @nbrys