provider/aws: Add support for iam_role tp force_detach_policies #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #883 ``` % make testacc TEST=./aws TESTARGS='-run=TestAccAWSIAMRole_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -run=TestAccAWSIAMRole_ -timeout 120m === RUN TestAccAWSIAMRole_importBasic --- PASS: TestAccAWSIAMRole_importBasic (90.60s) === RUN TestAccAWSIAMRole_basic --- PASS: TestAccAWSIAMRole_basic (63.38s) === RUN TestAccAWSIAMRole_basicWithDescription --- PASS: TestAccAWSIAMRole_basicWithDescription (160.94s) === RUN TestAccAWSIAMRole_namePrefix --- PASS: TestAccAWSIAMRole_namePrefix (82.85s) === RUN TestAccAWSIAMRole_testNameChange --- PASS: TestAccAWSIAMRole_testNameChange (104.43s) === RUN TestAccAWSIAMRole_badJSON --- PASS: TestAccAWSIAMRole_badJSON (5.03s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 507.244s ```
stack72
added
the
enhancement
radeksimko
approved these changes
Jun 19, 2017
| RoleName: aws.String(d.Id()), | ||
| }) | ||
| if err != nil { | ||
| return fmt.Errorf("Error listing Policies for IAM Role (%s) when trying to delete: %s", d.Id(), err) |
There was a problem hiding this comment.
I appreciate the descriptive error message here ❤️
aws/resource_aws_iam_role.go
Outdated
| if err != nil { | ||
| return fmt.Errorf("Error listing Policies for IAM Role (%s) when trying to delete: %s", d.Id(), err) | ||
| } | ||
| // Loop and remove this Role from any Profiles |
There was a problem hiding this comment.
and remove these Policies from the Role ? 😉
There was a problem hiding this comment.
Update made - will merge on green ;)
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #883