New resource: aws_apigatewayv2_model #8912

ewbankkit · 2019-06-07T21:32:58Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Another resource for #7004.

Release note for CHANGELOG:

FEATURES:

* New Resource: aws_apigatewayv2_model

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGateway2Model_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSAPIGateway2Model_ -timeout 120m
=== RUN   TestAccAWSAPIGateway2Model_basic
=== PAUSE TestAccAWSAPIGateway2Model_basic
=== RUN   TestAccAWSAPIGateway2Model_AllAttributes
=== PAUSE TestAccAWSAPIGateway2Model_AllAttributes
=== CONT  TestAccAWSAPIGateway2Model_basic
=== CONT  TestAccAWSAPIGateway2Model_AllAttributes
--- PASS: TestAccAWSAPIGateway2Model_basic (24.81s)
--- PASS: TestAccAWSAPIGateway2Model_AllAttributes (59.71s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	59.810s

~~Currently based on #8842, will need to rebase once that PR is merged.~~

ewbankkit · 2019-07-01T16:34:07Z

Rebased to track #8842 (comment).

ewbankkit · 2019-07-26T20:18:33Z

Rebased to fix merge conflict.
Acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGateway2Model_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSAPIGateway2Model_ -timeout 120m
=== RUN   TestAccAWSAPIGateway2Model_basic
=== PAUSE TestAccAWSAPIGateway2Model_basic
=== RUN   TestAccAWSAPIGateway2Model_AllAttributes
=== PAUSE TestAccAWSAPIGateway2Model_AllAttributes
=== CONT  TestAccAWSAPIGateway2Model_basic
=== CONT  TestAccAWSAPIGateway2Model_AllAttributes
--- PASS: TestAccAWSAPIGateway2Model_basic (21.47s)
--- PASS: TestAccAWSAPIGateway2Model_AllAttributes (48.11s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	48.137s

ewbankkit · 2020-03-09T22:24:36Z

Rebased to remove merge conflicts.
Re-ran acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2Model_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2Model_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayV2Model_basic
=== PAUSE TestAccAWSAPIGatewayV2Model_basic
=== RUN   TestAccAWSAPIGatewayV2Model_disappears
=== PAUSE TestAccAWSAPIGatewayV2Model_disappears
=== RUN   TestAccAWSAPIGatewayV2Model_AllAttributes
=== PAUSE TestAccAWSAPIGatewayV2Model_AllAttributes
=== CONT  TestAccAWSAPIGatewayV2Model_basic
=== CONT  TestAccAWSAPIGatewayV2Model_AllAttributes
=== CONT  TestAccAWSAPIGatewayV2Model_disappears
--- PASS: TestAccAWSAPIGatewayV2Model_disappears (23.42s)
--- PASS: TestAccAWSAPIGatewayV2Model_basic (27.38s)
--- PASS: TestAccAWSAPIGatewayV2Model_AllAttributes (59.17s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	59.213s

ewbankkit · 2020-03-13T12:17:34Z

After merge of #8842, incorporate all the feedback:

Change resource name to aws_apigatewayv2_blah; Rename source files
Add subcategory: "API Gateway v2 (WebSocket and HTTP APIs)" to documentation
Change function names to ApiGatewayV2
Add _disappears acceptance test
Use multierror in any test sweeper

ewbankkit · 2020-03-13T12:48:31Z

Renamed resource to aws_apigatewayv2_model.
Re-ran acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2Model_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2Model_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayV2Model_basic
=== PAUSE TestAccAWSAPIGatewayV2Model_basic
=== RUN   TestAccAWSAPIGatewayV2Model_disappears
=== PAUSE TestAccAWSAPIGatewayV2Model_disappears
=== RUN   TestAccAWSAPIGatewayV2Model_AllAttributes
=== PAUSE TestAccAWSAPIGatewayV2Model_AllAttributes
=== CONT  TestAccAWSAPIGatewayV2Model_basic
=== CONT  TestAccAWSAPIGatewayV2Model_AllAttributes
=== CONT  TestAccAWSAPIGatewayV2Model_disappears
--- PASS: TestAccAWSAPIGatewayV2Model_basic (27.39s)
--- PASS: TestAccAWSAPIGatewayV2Model_disappears (27.85s)
--- PASS: TestAccAWSAPIGatewayV2Model_AllAttributes (61.90s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	61.953s

ewbankkit · 2020-03-16T22:23:24Z

This is now ready for review.

gdavison

LGTM 🚀

--- PASS: TestAccAWSAPIGatewayV2Model_disappears (9.08s)
--- PASS: TestAccAWSAPIGatewayV2Model_basic (16.30s)
--- PASS: TestAccAWSAPIGatewayV2Model_AllAttributes (27.84s)

gdavison · 2020-04-07T19:52:11Z

aws/resource_aws_apigatewayv2_model_test.go

+					resource.TestCheckResourceAttr(resourceName, "content_type", "application/json"),
+					resource.TestCheckResourceAttr(resourceName, "description", ""),
+					resource.TestCheckResourceAttr(resourceName, "name", rName),
+					resource.TestCheckResourceAttr(resourceName, "schema", schema),


The function testAccCheckResourceAttrEquivalentJSON can be used so that both JSON objects can be normalized

gdavison · 2020-04-07T19:54:33Z

aws/resource_aws_apigatewayv2_model_test.go

+  }
+}
+`
+	schema2 := `


For readability, please update the formatting on schema2 to match other JSON strings

ewbankkit · 2020-04-07T21:43:26Z

Rebased to pick up testAccCheckResourceAttrEquivalentJSON and made suggested acceptance test changes.

ghost · 2020-04-10T00:37:59Z

This has been released in version 2.57.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

ghost · 2020-05-09T17:10:07Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

ewbankkit changed the title ~~[WIP] New resource: aws_api_gateway_v2_route~~ [WIP] New resource: aws_api_gateway_v2_model Jun 7, 2019

ewbankkit mentioned this pull request Jun 7, 2019

API Gateway- Websocket #7004

Closed

ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_model branch from 51f0ed3 to 9d494ab Compare June 11, 2019 14:43

ewbankkit mentioned this pull request Jun 11, 2019

New resource: aws_apigatewayv2_route #8881

Merged

ewbankkit changed the title ~~[WIP] New resource: aws_api_gateway_v2_model~~ New resource: aws_api_gateway_v2_model Jun 11, 2019

aeschright requested a review from a team June 21, 2019 19:04

ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_model branch from 1a31e17 to b422661 Compare July 1, 2019 16:33

ghost added service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. size/XXL Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Jul 1, 2019

ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_model branch from b422661 to ba8fb18 Compare July 2, 2019 17:29

ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_model branch from ba8fb18 to 6a21dc2 Compare July 26, 2019 20:18

aeschright added the new-resource Introduces a new resource. label Aug 19, 2019

ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_model branch from a8172b8 to 4c80818 Compare March 9, 2020 22:23

ewbankkit changed the title ~~New resource: aws_api_gateway_v2_model~~ New resource: aws_apigatewayv2_model Mar 13, 2020

ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_model branch from 4c80818 to 3a96ff7 Compare March 13, 2020 12:29

ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/XXL Managed by automation to categorize the size of a PR. labels Mar 13, 2020

ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_model branch from 3a96ff7 to 78f1007 Compare March 13, 2020 12:31

ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_model branch from 8e64894 to 1148afd Compare March 16, 2020 20:53

gdavison approved these changes Apr 7, 2020

View reviewed changes

gdavison added this to the v2.57.0 milestone Apr 7, 2020

Kit Ewbank and others added 3 commits April 7, 2020 17:32

Add 'aws_api_gateway_v2_model' resource.

d1ca5f5

'aws_api_gateway2_model' -> 'aws_apigatewayv2_model'.

7aa93cf

Use 'testAccCheckResourceAttrEquivalentJSON'.

d1f1d14

ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_model branch from 1148afd to d1f1d14 Compare April 7, 2020 21:42

gdavison merged commit 1e5bbb7 into hashicorp:master Apr 8, 2020

gdavison added a commit that referenced this pull request Apr 8, 2020

Update CHANGELOG for #8912

fbaf87c

ewbankkit deleted the issue-7004.aws_api_gateway_v2_model branch April 9, 2020 10:05

ewbankkit mentioned this pull request Apr 9, 2020

Fix missing side navigation links: aws_apigatewayv2_integration and aws_apigatewayv2_model #12746

Merged

ghost locked and limited conversation to collaborators May 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New resource: aws_apigatewayv2_model #8912

New resource: aws_apigatewayv2_model #8912

ewbankkit commented Jun 7, 2019 •

edited

Loading

ewbankkit commented Jul 1, 2019

ewbankkit commented Jul 26, 2019

ewbankkit commented Mar 9, 2020

ewbankkit commented Mar 13, 2020

ewbankkit commented Mar 13, 2020

ewbankkit commented Mar 16, 2020

gdavison left a comment

gdavison Apr 7, 2020

gdavison Apr 7, 2020

ewbankkit commented Apr 7, 2020

ghost commented Apr 10, 2020

ghost commented May 9, 2020

New resource: aws_apigatewayv2_model #8912

New resource: aws_apigatewayv2_model #8912

Conversation

ewbankkit commented Jun 7, 2019 • edited Loading

Community Note

ewbankkit commented Jul 1, 2019

ewbankkit commented Jul 26, 2019

ewbankkit commented Mar 9, 2020

ewbankkit commented Mar 13, 2020

ewbankkit commented Mar 13, 2020

ewbankkit commented Mar 16, 2020

gdavison left a comment

Choose a reason for hiding this comment

gdavison Apr 7, 2020

Choose a reason for hiding this comment

gdavison Apr 7, 2020

Choose a reason for hiding this comment

ewbankkit commented Apr 7, 2020

ghost commented Apr 10, 2020

ghost commented May 9, 2020

ewbankkit commented Jun 7, 2019 •

edited

Loading