-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Lex bot alias data source and resoruce #8919
Conversation
@jzbruno, and folks following along, my apologies for the longer than normal delays on pushing forward this feature. I haven't had the chance to devote the needed time get the other pull-requests into a mergable state 😳 I appreciate your patience as we continue to work through this resource. While I can't say that it will get into the next upcoming release(s), I can say that the resource is still a priority for us. To not give false expectations around the release of this resource I am going to remove the milestone. But let's coordinate on when would be ideal to continue pushing forward. If you find that your availability has also slowed please let me know if we should consider having another community member or the maintainers take over the pull-request(s). Cheers |
@nywilken I can continue to work on this. I believe this is ready for further review. |
@nywilken This one is ready for review. |
@gdavison Just FYI, I am updating this PR with the same review comments from the other Lex resource PRs, including adding the new fields. |
@gdavison Ok. When the intent and bot PRs are merged this one is ready for review too.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
--- PASS: TestAccDataSourceAwsLexBotAlias_basic (40.97s)
--- PASS: TestAccAwsLexBotAlias_botVersion (76.18s)
--- PASS: TestAccAwsLexBotAlias_disappears (158.05s)
--- PASS: TestAccAwsLexBotAlias_basic (194.58s)
--- PASS: TestAccAwsLexBotAlias_conversationLogsAudio (197.02s)
--- PASS: TestAccAwsLexBotAlias_conversationLogsText (198.77s)
--- PASS: TestAccAwsLexBotAlias_conversationLogsBoth (203.08s)
--- PASS: TestAccAwsLexBotAlias_description (259.16s)
This has been released in version 3.10.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Relates #905 and split from PR #2616
Release note for CHANGELOG:
Output from acceptance testing: