Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final retries after timeouts for various Neptune resources #9036

Merged
merged 4 commits into from
Jun 19, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions aws/resource_aws_neptune_cluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,13 @@ func resourceAwsNeptuneClusterCreate(d *schema.ResourceData, meta interface{}) e
}
return nil
})
if isResourceTimeoutError(err) {
if restoreDBClusterFromSnapshot {
_, err = conn.RestoreDBClusterFromSnapshot(restoreDBClusterFromSnapshotInput)
} else {
_, err = conn.CreateDBCluster(createDbClusterInput)
}
}
if err != nil {
return fmt.Errorf("error creating Neptune Cluster: %s", err)
}
Expand Down Expand Up @@ -542,6 +549,9 @@ func resourceAwsNeptuneClusterUpdate(d *schema.ResourceData, meta interface{}) e
}
return nil
})
if isResourceTimeoutError(err) {
_, err = conn.ModifyDBCluster(req)
}
if err != nil {
return fmt.Errorf("Failed to modify Neptune Cluster (%s): %s", d.Id(), err)
}
Expand Down Expand Up @@ -636,6 +646,9 @@ func resourceAwsNeptuneClusterDelete(d *schema.ResourceData, meta interface{}) e
}
return nil
})
if isResourceTimeoutError(err) {
_, err = conn.DeleteDBCluster(&deleteOpts)
}
if err != nil {
return fmt.Errorf("Neptune Cluster cannot be deleted: %s", err)
}
Expand Down
6 changes: 6 additions & 0 deletions aws/resource_aws_neptune_cluster_instance.go
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,9 @@ func resourceAwsNeptuneClusterInstanceCreate(d *schema.ResourceData, meta interf
}
return nil
})
if isResourceTimeoutError(err) {
resp, err = conn.CreateDBInstance(createOpts)
}
if err != nil {
return fmt.Errorf("error creating Neptune Instance: %s", err)
}
Expand Down Expand Up @@ -407,6 +410,9 @@ func resourceAwsNeptuneClusterInstanceUpdate(d *schema.ResourceData, meta interf
}
return nil
})
if isResourceTimeoutError(err) {
_, err = conn.ModifyDBInstance(req)
}
if err != nil {
return fmt.Errorf("Error modifying Neptune Instance %s: %s", d.Id(), err)
}
Expand Down
25 changes: 21 additions & 4 deletions aws/resource_aws_neptune_parameter_group.go
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,9 @@ func resourceAwsNeptuneParameterGroupUpdate(d *schema.ResourceData, meta interfa
}
return nil
})
if isResourceTimeoutError(err) {
_, err = conn.ResetDBParameterGroup(&resetOpts)
}
if err != nil {
return fmt.Errorf("Error resetting Neptune Parameter Group: %s", err)
}
Expand Down Expand Up @@ -272,10 +275,10 @@ func resourceAwsNeptuneParameterGroupUpdate(d *schema.ResourceData, meta interfa
func resourceAwsNeptuneParameterGroupDelete(d *schema.ResourceData, meta interface{}) error {
conn := meta.(*AWSClient).neptuneconn

return resource.Retry(3*time.Minute, func() *resource.RetryError {
deleteOpts := neptune.DeleteDBParameterGroupInput{
DBParameterGroupName: aws.String(d.Id()),
}
deleteOpts := neptune.DeleteDBParameterGroupInput{
DBParameterGroupName: aws.String(d.Id()),
}
err := resource.Retry(3*time.Minute, func() *resource.RetryError {
_, err := conn.DeleteDBParameterGroup(&deleteOpts)
if err != nil {
if isAWSErr(err, neptune.ErrCodeDBParameterGroupNotFoundFault, "") {
Expand All @@ -288,4 +291,18 @@ func resourceAwsNeptuneParameterGroupDelete(d *schema.ResourceData, meta interfa
}
return nil
})

if isResourceTimeoutError(err) {
_, err = conn.DeleteDBParameterGroup(&deleteOpts)
}

if isAWSErr(err, neptune.ErrCodeDBParameterGroupNotFoundFault, "") {
return nil
}

if err != nil {
ryndaniels marked this conversation as resolved.
Show resolved Hide resolved
return fmt.Errorf("Error deleting Neptune Parameter Group: %s", err)
}

return nil
}