Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support resource tags for aws_media_store_container resource #9379

Conversation

teraken0509
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #9230

Release note for CHANGELOG:

resource/aws_media_store_container.go:  Add `tags` argument

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSMediaStoreContainer_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSMediaStoreContainer_ -timeout 120m
=== RUN   TestAccAWSMediaStoreContainer_basic
=== PAUSE TestAccAWSMediaStoreContainer_basic
=== RUN   TestAccAWSMediaStoreContainer_tags
=== PAUSE TestAccAWSMediaStoreContainer_tags
=== RUN   TestAccAWSMediaStoreContainer_import
=== PAUSE TestAccAWSMediaStoreContainer_import
=== CONT  TestAccAWSMediaStoreContainer_basic
=== CONT  TestAccAWSMediaStoreContainer_import
=== CONT  TestAccAWSMediaStoreContainer_tags
--- PASS: TestAccAWSMediaStoreContainer_import (119.22s)
--- PASS: TestAccAWSMediaStoreContainer_basic (149.25s)
--- PASS: TestAccAWSMediaStoreContainer_tags (195.27s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	195.380s

@teraken0509 teraken0509 requested a review from a team July 17, 2019 10:24
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/mediastore Issues and PRs that pertain to the mediastore service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 17, 2019
@teraken0509 teraken0509 force-pushed the feature/add-support-resource-tags-for-aws_media_store_container-resource branch from bed5f85 to 9809327 Compare July 17, 2019 10:41
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Jul 17, 2019
@teraken0509 teraken0509 force-pushed the feature/add-support-resource-tags-for-aws_media_store_container-resource branch from 9809327 to 3bf1c52 Compare July 17, 2019 15:45
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 18, 2019
@bflad bflad added this to the v2.20.0 milestone Jul 18, 2019
@bflad bflad self-assigned this Jul 18, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kterada0509 🚀

--- PASS: TestAccAWSMediaStoreContainer_basic (94.82s)
--- PASS: TestAccAWSMediaStoreContainer_tags (104.36s)
--- PASS: TestAccAWSMediaStoreContainer_import (128.90s)

@bflad bflad merged commit 872e638 into hashicorp:master Jul 18, 2019
bflad added a commit that referenced this pull request Jul 18, 2019
@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
@teraken0509 teraken0509 deleted the feature/add-support-resource-tags-for-aws_media_store_container-resource branch March 5, 2020 14:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/mediastore Issues and PRs that pertain to the mediastore service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS Elemental MediaStore container tagging
2 participants