Add support for cloudwatch event target import #9431

chaspy · 2019-07-21T11:58:20Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

resource/aws_cloudwatch_event_target: Support resource import

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCloudWatchEventTarget_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSCloudWatchEventTarget_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSCloudWatchEventTarget_basic
=== PAUSE TestAccAWSCloudWatchEventTarget_basic
=== CONT  TestAccAWSCloudWatchEventTarget_basic
--- PASS: TestAccAWSCloudWatchEventTarget_basic (59.97s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	60.034s

ryndaniels · 2019-07-22T14:22:00Z

aws/resource_aws_cloudwatch_event_target_test.go

+				ImportState:       true,
+				ImportStateIdFunc: testAccAWSCloudWatchEventTargetImportStateIdFunc("aws_cloudwatch_event_target.moobar"),
+				ImportStateVerify: true,
+			},


Hi @chaspy - thanks so much for this contribution! Overall, this looks great, but for the sake of completeness, could you add this block to all of the TestAccAWSCloudWatchEventTarget acceptance tests in this file?

{ ResourceName: "aws_cloudwatch_event_target.moobar", ImportState: true, ImportStateIdFunc: testAccAWSCloudWatchEventTargetImportStateIdFunc("aws_cloudwatch_event_target.moobar"), ImportStateVerify: true, },

You'll want to make sure that ResourceName matches for each test since it looks like they vary a bit from test to test. If you're able to add these and re-run the acceptance tests for us, we can go ahead and get this merged in. Thanks! 👍

chaspy · 2019-07-23T16:29:21Z

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCloudWatchEventTarget_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSCloudWatchEventTarget_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSCloudWatchEventTarget_basic
=== PAUSE TestAccAWSCloudWatchEventTarget_basic
=== CONT  TestAccAWSCloudWatchEventTarget_basic
--- PASS: TestAccAWSCloudWatchEventTarget_basic (68.25s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	68.305s

$ make testacc TESTARGS='-run=TestAccAWSCloudWatchEventTarget_missingTargetId'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSCloudWatchEventTarget_missingTargetId -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSCloudWatchEventTarget_missingTargetId
=== PAUSE TestAccAWSCloudWatchEventTarget_missingTargetId
=== CONT  TestAccAWSCloudWatchEventTarget_missingTargetId
--- PASS: TestAccAWSCloudWatchEventTarget_missingTargetId (39.58s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	39.643s

$ make testacc TESTARGS='-run=TestAccAWSCloudWatchEventTarget_full'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSCloudWatchEventTarget_full -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSCloudWatchEventTarget_full
=== PAUSE TestAccAWSCloudWatchEventTarget_full
=== CONT  TestAccAWSCloudWatchEventTarget_full
--- PASS: TestAccAWSCloudWatchEventTarget_full (113.50s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	113.561s

$ make testacc TESTARGS='-run=TestAccAWSCloudWatchEventTarget_ssmDocument'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSCloudWatchEventTarget_ssmDocument -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSCloudWatchEventTarget_ssmDocument
=== PAUSE TestAccAWSCloudWatchEventTarget_ssmDocument
=== CONT  TestAccAWSCloudWatchEventTarget_ssmDocument
--- PASS: TestAccAWSCloudWatchEventTarget_ssmDocument (45.69s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	45.751s

$ make testacc TESTARGS='-run=TestAccAWSCloudWatchEventTarget_batch'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSCloudWatchEventTarget_batch -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSCloudWatchEventTarget_batch
=== PAUSE TestAccAWSCloudWatchEventTarget_batch
=== CONT  TestAccAWSCloudWatchEventTarget_batch
--- PASS: TestAccAWSCloudWatchEventTarget_batch (156.70s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	156.753s

$ make testacc TESTARGS='-run=TestAccAWSCloudWatchEventTarget_kinesis'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSCloudWatchEventTarget_kinesis -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSCloudWatchEventTarget_kinesis
=== PAUSE TestAccAWSCloudWatchEventTarget_kinesis
=== CONT  TestAccAWSCloudWatchEventTarget_kinesis
--- PASS: TestAccAWSCloudWatchEventTarget_kinesis (113.28s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	113.348s

$ make testacc TESTARGS='-run=TestAccAWSCloudWatchEventTarget_sqs'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSCloudWatchEventTarget_sqs -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSCloudWatchEventTarget_sqs
=== PAUSE TestAccAWSCloudWatchEventTarget_sqs
=== CONT  TestAccAWSCloudWatchEventTarget_sqs
--- PASS: TestAccAWSCloudWatchEventTarget_sqs (39.36s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	39.420s

$ make testacc TESTARGS='-run=TestAccAWSCloudWatchEventTarget_input_transformer'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSCloudWatchEventTarget_input_transformer -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSCloudWatchEventTarget_input_transformer
=== PAUSE TestAccAWSCloudWatchEventTarget_input_transformer
=== CONT  TestAccAWSCloudWatchEventTarget_input_transformer
--- PASS: TestAccAWSCloudWatchEventTarget_input_transformer (52.70s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	52.755s

chaspy · 2019-07-23T16:58:31Z

😢

$ make testacc TESTARGS='-run=TestAccAWSCloudWatchEventTarget_ecs'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSCloudWatchEventTarget_ecs -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSCloudWatchEventTarget_ecs
=== PAUSE TestAccAWSCloudWatchEventTarget_ecs
=== CONT  TestAccAWSCloudWatchEventTarget_ecs
--- FAIL: TestAccAWSCloudWatchEventTarget_ecs (157.06s)
    testing.go:629: Error destroying resource! WARNING: Dangling resources
        may exist. The full state and error is shown below.

        Error: errors during apply: ClusterContainsTasksException: The Cluster cannot be deleted while Tasks are active.
        	status code: 400, request id: bc6f1319-d58c-4c86-81cd-21588689410c

        State: aws_ecs_cluster.test:
          ID = arn:aws:ecs:us-west-2:655123516369:cluster/tf_ecs_target-7311645963352831750
          provider = provider.aws
          arn = arn:aws:ecs:us-west-2:655123516369:cluster/tf_ecs_target-7311645963352831750
          name = tf_ecs_target-7311645963352831750
          tags.% = 0
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	157.117s
make: *** [testacc] Error 1

ryndaniels

Thanks for adding in the additional tests, @chaspy! 👍

--- PASS: TestAccAWSCloudWatchEventTarget_sqs (9.64s)
--- PASS: TestAccAWSCloudWatchEventTarget_missingTargetId (11.21s)
--- PASS: TestAccAWSCloudWatchEventTarget_ssmDocument (13.62s)
--- PASS: TestAccAWSCloudWatchEventTarget_ecs (13.89s)
--- PASS: TestAccAWSCloudWatchEventTarget_basic (15.58s)
--- PASS: TestAccAWSCloudWatchEventTarget_input_transformer (28.17s)
--- PASS: TestAccAWSCloudWatchEventTarget_kinesis (78.65s)
--- PASS: TestAccAWSCloudWatchEventTarget_full (79.37s)
--- PASS: TestAccAWSCloudWatchEventTarget_batch (80.64s)

🚀

bflad · 2019-07-26T00:41:12Z

This has been released in version 2.21.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests, documentation updates, or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

ghost · 2019-11-02T15:11:15Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

ghost added size/L Managed by automation to categorize the size of a PR. service/cloudwatchevents documentation Introduces or discusses updates to documentation. labels Jul 21, 2019

chaspy added 2 commits July 22, 2019 00:28

Support for cloud watch event target import

40b675b

Update doc for cloudwatch event target import

64c2fed

chaspy force-pushed the chaspy/import_cloudwatch_event_target branch from b1363d3 to 64c2fed Compare July 21, 2019 15:30

Add test for cloudwatch event target import

70b5e91

chaspy force-pushed the chaspy/import_cloudwatch_event_target branch from e719fd5 to 70b5e91 Compare July 21, 2019 15:59

chaspy changed the title ~~Chaspy/import cloudwatch event target~~ Add support for cloudwatch event target import Jul 21, 2019

chaspy marked this pull request as ready for review July 21, 2019 16:10

chaspy requested a review from a team July 21, 2019 16:10

ryndaniels suggested changes Jul 22, 2019

View reviewed changes

bflad assigned ryndaniels Jul 23, 2019

bflad added enhancement Requests to existing resources that expand the functionality or scope. waiting-response Maintainers are waiting on response from community or contributor. labels Jul 23, 2019

ghost added size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Jul 23, 2019

chaspy force-pushed the chaspy/import_cloudwatch_event_target branch from 67edbd2 to 98d0c6a Compare July 23, 2019 16:14

ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Jul 23, 2019

chaspy force-pushed the chaspy/import_cloudwatch_event_target branch from 98d0c6a to e5b0716 Compare July 23, 2019 16:33

Add import state to All TestAccAWSCloudWatchEventTarget test

d69b5e1

chaspy force-pushed the chaspy/import_cloudwatch_event_target branch from e5b0716 to d69b5e1 Compare July 23, 2019 17:19

ryndaniels approved these changes Jul 24, 2019

View reviewed changes

ryndaniels added this to the v2.21.0 milestone Jul 24, 2019

ryndaniels merged commit b3cc187 into hashicorp:master Jul 24, 2019

chaspy deleted the chaspy/import_cloudwatch_event_target branch July 25, 2019 02:33

ryndaniels mentioned this pull request Jul 31, 2019

Add support for lambda permission import #9369

Merged

ghost locked and limited conversation to collaborators Nov 2, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for cloudwatch event target import #9431

Add support for cloudwatch event target import #9431

chaspy commented Jul 21, 2019 •

edited

Loading

ryndaniels Jul 22, 2019

chaspy commented Jul 23, 2019 •

edited

Loading

chaspy commented Jul 23, 2019

ryndaniels left a comment

bflad commented Jul 26, 2019

ghost commented Nov 2, 2019

Add support for cloudwatch event target import #9431

Add support for cloudwatch event target import #9431

Conversation

chaspy commented Jul 21, 2019 • edited Loading

Community Note

ryndaniels Jul 22, 2019

Choose a reason for hiding this comment

chaspy commented Jul 23, 2019 • edited Loading

chaspy commented Jul 23, 2019

ryndaniels left a comment

Choose a reason for hiding this comment

bflad commented Jul 26, 2019

ghost commented Nov 2, 2019

chaspy commented Jul 21, 2019 •

edited

Loading

chaspy commented Jul 23, 2019 •

edited

Loading