Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Server-Side Encryption to SQS #962

Merged
merged 1 commit into from
Jul 3, 2017

Conversation

brandonstevens
Copy link
Contributor

AWS recently added support for server-side encryption (SSE to SQS. This updates the aws_sqs_queue resource to include two SSE attributes. Updated code, tests, and docs. Ran acceptance tests.

Marked as a WIP for a couple reasons:

  • First time contributing to the project. No idea if I missed anything.
  • There is an edge case with KmsDataKeyReusePeriodSeconds that I need advice on how to handle. In the AWS API, when KmsDataKeyReusePeriodSeconds is set, but KmsMasterKeyId is not set, the API does not encrypt the queue and ignores KmsDataKeyReusePeriodSeconds. The code as it stands makes the API call and silently saves kms_data_key_reuse_period_seconds to the state even though it's not used.

Signed-off-by: Brandon Stevens <stevens.brandon@gmail.com>
@radeksimko radeksimko added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 3, 2017
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @brandonstevens
your PR looks great. Good test coverage.

Regarding the second concern about KmsDataKeyReusePeriodSeconds - there are long-term plans on supporting RequiredWhen in the schema, so we could express a case when a field is only required under certain conditions. Unfortunately we don't support that yet, so we can either leave it fail silently (current situation) or add a simple condition to the CRUD. I think the first option is OK.

@radeksimko radeksimko changed the title [WIP] Add support for Server-Side Encryption to SQS Add support for Server-Side Encryption to SQS Jul 3, 2017
@radeksimko radeksimko merged commit 9f56b86 into hashicorp:master Jul 3, 2017
@brandonstevens brandonstevens deleted the aws-sqs-sse branch October 15, 2017 18:29
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants