Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final retry after timeout creating DMS endpoint #9695

Merged
merged 1 commit into from
Aug 12, 2019
Merged

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #7873

Release note for CHANGELOG:

BUG FIXES:
* resource/aws_dms_endpoint: Final retry after timeout creating DMS endpoint

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAwsDmsEndpoint"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAwsDmsEndpoint -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAwsDmsEndpoint_Basic
=== PAUSE TestAccAwsDmsEndpoint_Basic
=== RUN   TestAccAwsDmsEndpoint_S3
=== PAUSE TestAccAwsDmsEndpoint_S3
=== RUN   TestAccAwsDmsEndpoint_DynamoDb
=== PAUSE TestAccAwsDmsEndpoint_DynamoDb
=== RUN   TestAccAwsDmsEndpoint_MongoDb
=== PAUSE TestAccAwsDmsEndpoint_MongoDb
=== RUN   TestAccAwsDmsEndpoint_DocDB
=== PAUSE TestAccAwsDmsEndpoint_DocDB
=== RUN   TestAccAwsDmsEndpoint_Db2
=== PAUSE TestAccAwsDmsEndpoint_Db2
=== CONT  TestAccAwsDmsEndpoint_Basic
=== CONT  TestAccAwsDmsEndpoint_Db2
=== CONT  TestAccAwsDmsEndpoint_MongoDb
=== CONT  TestAccAwsDmsEndpoint_DocDB
=== CONT  TestAccAwsDmsEndpoint_DynamoDb
=== CONT  TestAccAwsDmsEndpoint_S3
--- PASS: TestAccAwsDmsEndpoint_DocDB (50.58s)
--- PASS: TestAccAwsDmsEndpoint_Db2 (50.63s)
--- PASS: TestAccAwsDmsEndpoint_Basic (50.73s)
--- PASS: TestAccAwsDmsEndpoint_MongoDb (63.22s)
--- PASS: TestAccAwsDmsEndpoint_DynamoDb (64.79s)
--- PASS: TestAccAwsDmsEndpoint_S3 (67.94s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       70.171s

@ryndaniels ryndaniels requested a review from a team August 9, 2019 09:53
@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/databasemigrationservice tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 9, 2019
@ryndaniels ryndaniels added the bug Addresses a defect in current functionality. label Aug 9, 2019
@ryndaniels ryndaniels added this to the v2.24.0 milestone Aug 9, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAwsDmsEndpoint_DocDB (13.87s)
--- PASS: TestAccAwsDmsEndpoint_Basic (14.49s)
--- PASS: TestAccAwsDmsEndpoint_Db2 (14.62s)
--- PASS: TestAccAwsDmsEndpoint_MongoDb (16.31s)
--- PASS: TestAccAwsDmsEndpoint_S3 (33.84s)
--- PASS: TestAccAwsDmsEndpoint_DynamoDb (34.15s)

@@ -11,7 +11,7 @@ import (
"github.com/hashicorp/terraform/terraform"
)

func TestAccAwsDmsEndpointBasic(t *testing.T) {
func TestAccAwsDmsEndpoint_Basic(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ryndaniels ryndaniels merged commit e655619 into master Aug 12, 2019
@ryndaniels ryndaniels deleted the rfd-retry-dms branch August 12, 2019 11:30
@ghost
Copy link

ghost commented Aug 15, 2019

This has been released in version 2.24.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants