Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of terraform.NewResourceConfig #9709

Merged
merged 1 commit into from
Sep 6, 2019
Merged

Remove usage of terraform.NewResourceConfig #9709

merged 1 commit into from
Sep 6, 2019

Conversation

appilon
Copy link
Contributor

@appilon appilon commented Aug 9, 2019

the config package (co-dependent of terraform.NewResourceConfig) is being removed. The new function terraform.NewResourceConfigRaw should replace both of them.

@appilon appilon requested a review from a team August 9, 2019 19:49
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. dependencies Used to indicate dependency changes. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 9, 2019
@aeschright aeschright added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Aug 9, 2019
@aeschright
Copy link
Contributor

Holding till next week's tf release.

@bflad
Copy link
Contributor

bflad commented Aug 31, 2019

Terraform v0.12.7 is now merged. This is ready for rebase/resubmission. 👍

@appilon appilon force-pushed the appilon/remove-config-pkg branch from 846ea5a to aa5561f Compare September 6, 2019 02:28
@appilon appilon force-pushed the appilon/remove-config-pkg branch from aa5561f to b7d31a2 Compare September 6, 2019 02:33
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. and removed size/XXL Managed by automation to categorize the size of a PR. labels Sep 6, 2019
@appilon
Copy link
Contributor Author

appilon commented Sep 6, 2019

PR is ready for review

bflad
bflad approved these changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSProvider_Region_AwsChina (2.96s)
--- PASS: TestAccAWSProvider_Region_AwsCommercial (3.01s)
--- PASS: TestAccAWSProvider_Region_AwsGovCloudUs (3.03s)
--- PASS: TestAccAWSProvider_Endpoints_Deprecated (3.21s)
--- PASS: TestAccAWSProvider_Endpoints (3.22s)

@bflad bflad added this to the v2.28.0 milestone Sep 6, 2019
@bflad bflad merged commit 4392b42 into master Sep 6, 2019
@bflad bflad deleted the appilon/remove-config-pkg branch September 6, 2019 02:41
@ghost
Copy link

ghost commented Sep 12, 2019

This has been released in version 2.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
dependencies Used to indicate dependency changes. size/XS Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.28.0
Development

Successfully merging this pull request may close these issues.
3 participants
@appilon @aeschright @bflad