resource/aws_cognito_user_pool: Fix perpetual diffs on sms_verification_message #9758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
service/cognito
tests
nywilken
force-pushed
the
b-aws_cognito_user_pool-sms-verification-message
branch
from
35ad1cc to
14c7a81
Compare
paddycarver
approved these changes
Aug 14, 2019
|
@aeschright should this PR be retracted in favour of the longer term solution specified in #9791 |
…on_message
When using `verification_message_template.sms_message` for setting the sms message verification template the resource upon subsequent applys will trigger an update because of a diff in the conflicting `sms_verification_message` argument. This changes adds the computed property onto `sms_message_verification` to ensure it get's updated with the contents being set by `verification_message_template.sms_message`
Acceptance test before change
```
--- FAIL: TestAccAWSCognitoUserPool_withVerificationMessageTemplate (10.90s) [274/322]
testing.go:568: Step 0 error: After applying this step, the plan was not empty:
DIFF:
UPDATE: aws_cognito_user_pool.pool
sms_verification_message: "{####} Baz" => ""
```
Acceptance test after change
```
--- PASS: TestAccAWSCognitoUserPool_withVerificationMessageTemp
```
nywilken
force-pushed
the
b-aws_cognito_user_pool-sms-verification-message
branch
from
14c7a81 to
ac48305
Compare
ghost
added
size/S
nywilken
force-pushed
the
b-aws_cognito_user_pool-sms-verification-message
branch
from
ac48305 to
a20cadf
Compare
aeschright
approved these changes
Sep 4, 2019
nywilken
force-pushed
the
b-aws_cognito_user_pool-sms-verification-message
branch
from
a20cadf to
b0c5ef4
Compare
nywilken
deleted the
b-aws_cognito_user_pool-sms-verification-message
branch
nywilken
added a commit
that referenced
this pull request
Sep 6, 2019
|
This has been released in version 2.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
No specific issues found that pertaining to this bug.
Release note for CHANGELOG:
When using
verification_message_template.sms_messagefor setting the sms message verification template the resource upon subsequent applys will trigger an update because of a diff in the conflictingsms_verification_messageargument. This changes adds the computed property ontosms_message_verificationto ensure it get's updated with the contents being set byverification_message_template.sms_messageAcceptance test before change
Acceptance test after change