-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resources: aws_fsx_lustre_file_system and aws_fsx_windows_file_system #9761
Merged
Commits on Jan 9, 2019
-
Configuration menu - View commit details
-
Copy full SHA for d1107e3 - Browse repository at this point
Copy the full SHA d1107e3View commit details
Commits on Feb 7, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 9391452 - Browse repository at this point
Copy the full SHA 9391452View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b028d8 - Browse repository at this point
Copy the full SHA 7b028d8View commit details
Commits on Apr 11, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 3e704d8 - Browse repository at this point
Copy the full SHA 3e704d8View commit details
Commits on Jul 10, 2019
-
Configuration menu - View commit details
-
Copy full SHA for f72ef0a - Browse repository at this point
Copy the full SHA f72ef0aView commit details
Commits on Aug 9, 2019
-
Configuration menu - View commit details
-
Copy full SHA for f63d3c0 - Browse repository at this point
Copy the full SHA f63d3c0View commit details
Commits on Aug 12, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 01f58be - Browse repository at this point
Copy the full SHA 01f58beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ea615a - Browse repository at this point
Copy the full SHA 8ea615aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 25e6775 - Browse repository at this point
Copy the full SHA 25e6775View commit details
Commits on Aug 13, 2019
-
Merge branch 'resource-fsx-file-system' of https://github.com/slapula…
…/terraform-provider-aws into slapula-resource-fsx-file-system
Configuration menu - View commit details
-
Copy full SHA for 170648a - Browse repository at this point
Copy the full SHA 170648aView commit details
Commits on Aug 14, 2019
-
New Resources: aws_fsx_lustre_file_system and aws_fsx_windows_file_sy…
…stem Reference: #7035 Reference: #7074 Builds on #7074 with the following changes: - Split into two separate resources (`aws_fsx_lustre_file_system` and `aws_fsx_windows_file_system`) to simplify practitioner configuration (e.g. lose the required configuration blocks), ease maintenance for resource logic and single file system arguments (e.g. `kms_key_id` only for Windows), and enhance validations (e.g. `storage_capacity` differences between file systems) - Add covering acceptance testing with updates/force new for all arguments - Better alignment with API naming for some arguments (e.g. changing `capacity` into `storage_capacity` to remove ambiguity with `throughput_capacity`) - Implement [resource Customizable Timeouts](https://www.terraform.io/docs/extend/resources/retries-and-customizable-timeouts.html) - Implement `skip_final_backup` argument for Windows - Implement `network_interface_ids`, `owner_id`, and `vpc_id` attributes - Augment resource documentation with additional notes found in [API reference](https://docs.aws.amazon.com/fsx/latest/APIReference/) and clarify `security_group_ids` import behavior Output from acceptance testing: ``` --- PASS: TestAccAWSFsxLustreFileSystem_Tags (458.62s) --- PASS: TestAccAWSFsxLustreFileSystem_basic (526.79s) --- PASS: TestAccAWSFsxLustreFileSystem_disappears (564.58s) --- PASS: TestAccAWSFsxLustreFileSystem_WeeklyMaintenanceStartTime (697.83s) --- PASS: TestAccAWSFsxLustreFileSystem_StorageCapacity (940.13s) --- PASS: TestAccAWSFsxLustreFileSystem_SecurityGroupIds (1074.08s) --- PASS: TestAccAWSFsxLustreFileSystem_ImportedFileChunkSize (1276.18s) --- PASS: TestAccAWSFsxLustreFileSystem_ImportPath (1322.13s) --- PASS: TestAccAWSFsxLustreFileSystem_ExportPath (1338.75s) --- PASS: TestAccAWSFsxWindowsFileSystem_Tags (2256.64s) --- PASS: TestAccAWSFsxWindowsFileSystem_WeeklyMaintenanceStartTime (2346.44s) --- PASS: TestAccAWSFsxWindowsFileSystem_basic (2404.35s) --- PASS: TestAccAWSFsxWindowsFileSystem_disappears (2412.10s) --- PASS: TestAccAWSFsxWindowsFileSystem_AutomaticBackupRetentionDays (2514.61s) --- PASS: TestAccAWSFsxWindowsFileSystem_DailyAutomaticBackupStartTime (2849.43s) --- PASS: TestAccAWSFsxWindowsFileSystem_SelfManagedActiveDirectory (2850.64s) --- PASS: TestAccAWSFsxWindowsFileSystem_ThroughputCapacity (3292.44s) --- PASS: TestAccAWSFsxWindowsFileSystem_SecurityGroupIds (3609.37s) --- PASS: TestAccAWSFsxWindowsFileSystem_KmsKeyId (3977.10s) --- PASS: TestAccAWSFsxWindowsFileSystem_StorageCapacity (4026.67s) --- PASS: TestAccAWSFsxWindowsFileSystem_CopyTagsToBackups (4389.57s) ```
Configuration menu - View commit details
-
Copy full SHA for 446a22a - Browse repository at this point
Copy the full SHA 446a22aView commit details -
Update website/docs/r/fsx_lustre_file_system.html.markdown
Co-Authored-By: Ryn Daniels <ryn@hashicorp.com>
Configuration menu - View commit details
-
Copy full SHA for cc039ac - Browse repository at this point
Copy the full SHA cc039acView commit details -
Configuration menu - View commit details
-
Copy full SHA for f923aa6 - Browse repository at this point
Copy the full SHA f923aa6View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.