Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add glue CSV classifier #9824

Merged
merged 28 commits into from
Oct 11, 2019
Merged

Add glue CSV classifier #9824

merged 28 commits into from
Oct 11, 2019

Commits on Jun 25, 2019

  1. Start work on adding csv classifier per hashicorp#9083

    Thomas Wunderlich committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    bc2b69d View commit details
    Browse the repository at this point in the history

  2. Update conflictsWith

    Thomas Wunderlich committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    337743c View commit details
    Browse the repository at this point in the history

  3. Add CSV Classifier specific code

    Thomas Wunderlich committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    cf51098 View commit details
    Browse the repository at this point in the history

  4. Update forceNew with csv classifier options

    Thomas Wunderlich committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    4efc343 View commit details
    Browse the repository at this point in the history

  5. Fix the requireds with info from https://docs.aws.amazon.com/glue/lat… 

    …est/webapi/API_CreateCsvClassifierRequest.html
    Thomas Wunderlich committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    5e404dd View commit details
    Browse the repository at this point in the history

  6. It's Optional true, not Required false

    Thomas Wunderlich committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    534aa1d View commit details
    Browse the repository at this point in the history

  7. Fix typing for the header field

    Thomas Wunderlich committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    2267add View commit details
    Browse the repository at this point in the history

  8. Fix the typing for Glue classifier

    Thomas Wunderlich committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    2843fb3 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2019

  1. Start adding validation

    Thomas Wunderlich committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    d247480 View commit details
    Browse the repository at this point in the history

  2. Add expand and flatten methods (need to fix the types)

    Thomas Wunderlich committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    a9eff8c View commit details
    Browse the repository at this point in the history

  3. Validate the header options

    Thomas Wunderlich committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    d4661bb View commit details
    Browse the repository at this point in the history

  4. Go fmt issues

    Thomas Wunderlich committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    10d15a2 View commit details
    Browse the repository at this point in the history

  5. IDE is now working :)

    Thomas Wunderlich committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    0902257 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2019

  1. Run go fmt on code

    Thomas Wunderlich committed Aug 19, 2019
    Configuration menu
    Copy the full SHA
    533f4f4 View commit details
    Browse the repository at this point in the history

  2. Fix boolean types

    Thomas Wunderlich committed Aug 19, 2019
    Configuration menu
    Copy the full SHA
    ccd4936 View commit details
    Browse the repository at this point in the history

  3. Fix rest of typing

    Thomas Wunderlich committed Aug 19, 2019
    Configuration menu
    Copy the full SHA
    b8e744d View commit details
    Browse the repository at this point in the history

  4. Update existing tests with csvClassifier and start on csvClassifier t… 

    …ests
    Thomas Wunderlich committed Aug 19, 2019
    Configuration menu
    Copy the full SHA
    393fa05 View commit details
    Browse the repository at this point in the history

  5. WIP on tests. Need to write the tests for the csv classifier

    Thomas Wunderlich committed Aug 19, 2019
    Configuration menu
    Copy the full SHA
    29f0f40 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2019

  1. Finish writing the test

    Thomas Wunderlich committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    0b64a2f View commit details
    Browse the repository at this point in the history

  2. go fmt the file

    Thomas Wunderlich committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    1501cd1 View commit details
    Browse the repository at this point in the history

  3. Add documentation for the csv classifier

    Thomas Wunderlich committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    a82316a View commit details
    Browse the repository at this point in the history

  4. Fix the typing in the tests

    Thomas Wunderlich committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    8e0784b View commit details
    Browse the repository at this point in the history

  5. Add missing parameter

    Thomas Wunderlich committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    8e1c4e5 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2019

  1. Merge remote-tracking branch 'tpa/master' into twunderlich/9083-glue-… 

    …add-csv-classifier
    Thomas Wunderlich committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    c63e761 View commit details
    Browse the repository at this point in the history

  2. Fix warnings

    Thomas Wunderlich committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    a3f1934 View commit details
    Browse the repository at this point in the history

  3. Remove name as being part of the csv_classifier section

    Thomas Wunderlich committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    6518e9e View commit details
    Browse the repository at this point in the history

  4. Add quote_symbol back

    Thomas Wunderlich committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    2c76b7e View commit details
    Browse the repository at this point in the history

  5. Fix the expected format of list type attributes

    Thomas Wunderlich committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    acf4811 View commit details
    Browse the repository at this point in the history