Update rate based rule limit for WAF

[pasali]

https://aws.amazon.com/about-aws/whats-new/2019/08/lower-threshold-for-aws-waf-rate-based-rules/

[Ninir]

Hi @pasali,

thanks for the update! Can we also update the documentation?

• https://github.com/terraform-providers/terraform-provider-aws/blob/master/website/docs/r/waf_rate_based_rule.html.markdown
• https://github.com/terraform-providers/terraform-provider-aws/blob/master/website/docs/r/wafregional_rate_based_rule.html.markdown

[Ninir]

This looks good to me:

$ TF_ACC=1 go test ./... -v -parallel 4 -run=TestAccAWSWafRegionalRateBasedRule_ -timeout 120m                                                                                                                                                                                                                                                            [09/16/19 10:42:37 - 10160]
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSWafRegionalRateBasedRule_basic
=== PAUSE TestAccAWSWafRegionalRateBasedRule_basic
=== RUN   TestAccAWSWafRegionalRateBasedRule_changeNameForceNew
=== PAUSE TestAccAWSWafRegionalRateBasedRule_changeNameForceNew
=== RUN   TestAccAWSWafRegionalRateBasedRule_disappears
=== PAUSE TestAccAWSWafRegionalRateBasedRule_disappears
=== RUN   TestAccAWSWafRegionalRateBasedRule_changePredicates
=== PAUSE TestAccAWSWafRegionalRateBasedRule_changePredicates
=== RUN   TestAccAWSWafRegionalRateBasedRule_changeRateLimit
=== PAUSE TestAccAWSWafRegionalRateBasedRule_changeRateLimit
=== RUN   TestAccAWSWafRegionalRateBasedRule_noPredicates
=== PAUSE TestAccAWSWafRegionalRateBasedRule_noPredicates
=== CONT  TestAccAWSWafRegionalRateBasedRule_basic
=== CONT  TestAccAWSWafRegionalRateBasedRule_noPredicates
=== CONT  TestAccAWSWafRegionalRateBasedRule_changeRateLimit
=== CONT  TestAccAWSWafRegionalRateBasedRule_disappears
--- PASS: TestAccAWSWafRegionalRateBasedRule_noPredicates (36.11s)
=== CONT  TestAccAWSWafRegionalRateBasedRule_changePredicates
--- PASS: TestAccAWSWafRegionalRateBasedRule_disappears (55.42s)
=== CONT  TestAccAWSWafRegionalRateBasedRule_changeNameForceNew
--- PASS: TestAccAWSWafRegionalRateBasedRule_changeRateLimit (57.43s)
--- PASS: TestAccAWSWafRegionalRateBasedRule_basic (58.77s)
--- PASS: TestAccAWSWafRegionalRateBasedRule_changePredicates (69.95s)
--- PASS: TestAccAWSWafRegionalRateBasedRule_changeNameForceNew (81.61s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	138.302s


$ make testacc TESTARGS='-run=TestAccAWSWafRateBasedRule_'                                                                                                                    [09/15/19 21:16:18 - 10153]
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSWafRateBasedRule_ -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSWafRateBasedRule_basic
=== PAUSE TestAccAWSWafRateBasedRule_basic
=== RUN   TestAccAWSWafRateBasedRule_changeNameForceNew
=== PAUSE TestAccAWSWafRateBasedRule_changeNameForceNew
=== RUN   TestAccAWSWafRateBasedRule_disappears
=== PAUSE TestAccAWSWafRateBasedRule_disappears
=== RUN   TestAccAWSWafRateBasedRule_changePredicates
=== PAUSE TestAccAWSWafRateBasedRule_changePredicates
=== RUN   TestAccAWSWafRateBasedRule_noPredicates
=== PAUSE TestAccAWSWafRateBasedRule_noPredicates
=== CONT  TestAccAWSWafRateBasedRule_basic
=== CONT  TestAccAWSWafRateBasedRule_changePredicates
=== CONT  TestAccAWSWafRateBasedRule_disappears
=== CONT  TestAccAWSWafRateBasedRule_noPredicates
=== CONT  TestAccAWSWafRateBasedRule_changeNameForceNew
--- PASS: TestAccAWSWafRateBasedRule_noPredicates (28.86s)
--- PASS: TestAccAWSWafRateBasedRule_basic (47.86s)
--- PASS: TestAccAWSWafRateBasedRule_disappears (53.71s)
--- PASS: TestAccAWSWafRateBasedRule_changePredicates (75.00s)
--- PASS: TestAccAWSWafRateBasedRule_changeNameForceNew (82.80s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	85.997s

Thanks @pasali !

[vad]

I just updated the provider and it gives me the same error as before:

aws_wafregional_rate_based_rule.login_rule: Modifying... [id=<CUT>]

Error: Error updating WAF Regional Rate Based Rule Predicates (<CUT>): Error getting WAF regional change token: InvalidParameter: 1 validation error(s) found.
- minimum field value of 2000, UpdateRateBasedRuleInput.RateLimit.

$ terraform version
Terraform v0.12.9
+ provider.aws v2.29.0

Is it just me? Could it be that the AWS client should be updated too?

[bflad]

Hi @vad, its not likely just you. I reopened #10058 with details about the upstream issue(s) here: #10058 (comment)

[pasali]

Sorry for the error, i assumed aws would have changed their REST API.

[praveensastry]

FWIW, I tried updating the rate limit value to 100 through the web console and I could. cli is still throwing similar error though.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!