Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_elasticache_replication_group: Add reader_endpoint_address attribute #9979

Merged
merged 6 commits into from
Jan 5, 2021
Merged

r/aws_elasticache_replication_group: Add reader_endpoint_address attribute #9979

merged 6 commits into from
Jan 5, 2021

Conversation

1newsr
Copy link
Contributor

@1newsr 1newsr commented Sep 4, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

resource/aws_elasticache_replication_group: Add reader_endpoint_address attribute
data-source/aws_elasticache_replication_group: Add reader_endpoint_address attribute

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSElasticacheReplicationGroup_multiAzInVpc'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSElasticacheReplicationGroup_multiAzInVpc -timeout 120m
=== RUN   TestAccAWSElasticacheReplicationGroup_multiAzInVpc
=== PAUSE TestAccAWSElasticacheReplicationGroup_multiAzInVpc
=== CONT  TestAccAWSElasticacheReplicationGroup_multiAzInVpc
--- PASS: TestAccAWSElasticacheReplicationGroup_multiAzInVpc (1010.90s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1010.956s

I'm sorry that I could not execute basic tests in my environment.

@1newsr 1newsr requested a review from a team September 4, 2019 00:07
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/elasticache Issues and PRs that pertain to the elasticache service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 4, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Sep 4, 2019
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @1newsr. LGTM 🚀

--- PASS: TestAccAWSElasticacheReplicationGroup_clusteringAndCacheNodesCausesError (106.35s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateDescription (896.43s)
--- PASS: TestAccAWSElasticacheReplicationGroup_tags (956.32s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateMaintenanceWindow (1022.97s)
--- PASS: TestAccAWSElasticacheReplicationGroup_enableSnapshotting (1084.24s)
--- PASS: TestAccAWSElasticacheReplicationGroup_useCmkKmsKeyId (1109.62s)
--- PASS: TestAccAWSElasticacheReplicationGroup_enableAuthTokenTransitEncryption (1259.98s)
--- PASS: TestAccAWSElasticacheReplicationGroup_enableAtRestEncryption (1264.80s)
--- PASS: TestAccAWSElasticacheReplicationGroup_Uppercase (1446.56s)
--- PASS: TestAccAWSElasticacheReplicationGroup_multiAzInVpc (1762.99s)
--- PASS: TestAccAWSElasticacheReplicationGroup_basic (1944.02s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateParameterGroup (1950.46s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_Basic (1958.80s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateNodeSize (2033.46s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverDisabled (2051.81s)
--- PASS: TestAccAWSElasticacheReplicationGroup_vpc (2079.63s)
--- PASS: TestAccAWSElasticacheReplicationGroup_redisClusterInVpc2 (2093.36s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters (2136.00s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverEnabled (3309.13s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_NumNodeGroups (3902.21s)

--- PASS: TestAccDataSourceAwsElasticacheReplicationGroup_basic (902.16s)
--- PASS: TestAccDataSourceAwsElasticacheReplicationGroup_ClusterMode (1105.12s)

@ghost
Copy link

ghost commented Jan 8, 2021

This has been released in version 3.23.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Feb 5, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/elasticache Issues and PRs that pertain to the elasticache service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reader endpoint in aws_elasticache_replication_group
3 participants