Acceptance test import refactor for redshift resources

[ryndaniels]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #8944

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSRedshiftParameterGroup"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSRedshiftParameterGroup -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSRedshiftParameterGroup_basic
=== PAUSE TestAccAWSRedshiftParameterGroup_basic
=== RUN   TestAccAWSRedshiftParameterGroup_withParameters
=== PAUSE TestAccAWSRedshiftParameterGroup_withParameters
=== RUN   TestAccAWSRedshiftParameterGroup_withoutParameters
=== PAUSE TestAccAWSRedshiftParameterGroup_withoutParameters
=== RUN   TestAccAWSRedshiftParameterGroup_withTags
=== PAUSE TestAccAWSRedshiftParameterGroup_withTags
=== CONT  TestAccAWSRedshiftParameterGroup_basic
=== CONT  TestAccAWSRedshiftParameterGroup_withTags
=== CONT  TestAccAWSRedshiftParameterGroup_withoutParameters
=== CONT  TestAccAWSRedshiftParameterGroup_withParameters
--- PASS: TestAccAWSRedshiftParameterGroup_withoutParameters (31.15s)
--- PASS: TestAccAWSRedshiftParameterGroup_withParameters (31.55s)
--- PASS: TestAccAWSRedshiftParameterGroup_basic (31.56s)
--- PASS: TestAccAWSRedshiftParameterGroup_withTags (71.52s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       75.468s

make testacc TESTARGS="-run=TestAccAWSRedshiftSubnetGroup"     
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSRedshiftSubnetGroup -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSRedshiftSubnetGroup_basic
=== PAUSE TestAccAWSRedshiftSubnetGroup_basic
=== RUN   TestAccAWSRedshiftSubnetGroup_updateDescription
=== PAUSE TestAccAWSRedshiftSubnetGroup_updateDescription
=== RUN   TestAccAWSRedshiftSubnetGroup_updateSubnetIds
=== PAUSE TestAccAWSRedshiftSubnetGroup_updateSubnetIds
=== RUN   TestAccAWSRedshiftSubnetGroup_tags
=== PAUSE TestAccAWSRedshiftSubnetGroup_tags
=== CONT  TestAccAWSRedshiftSubnetGroup_basic
=== CONT  TestAccAWSRedshiftSubnetGroup_updateSubnetIds
=== CONT  TestAccAWSRedshiftSubnetGroup_updateDescription
=== CONT  TestAccAWSRedshiftSubnetGroup_tags
--- PASS: TestAccAWSRedshiftSubnetGroup_basic (59.54s)
--- PASS: TestAccAWSRedshiftSubnetGroup_tags (93.09s)
--- PASS: TestAccAWSRedshiftSubnetGroup_updateSubnetIds (106.19s)
--- PASS: TestAccAWSRedshiftSubnetGroup_updateDescription (106.32s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       108.163s

make testacc TESTARGS="-run=TestAccAWSRedshiftSecurityGroup"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSRedshiftSecurityGroup -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSRedshiftSecurityGroup_basic
=== PAUSE TestAccAWSRedshiftSecurityGroup_basic
=== RUN   TestAccAWSRedshiftSecurityGroup_ingressCidr
=== PAUSE TestAccAWSRedshiftSecurityGroup_ingressCidr
=== RUN   TestAccAWSRedshiftSecurityGroup_updateIngressCidr
=== PAUSE TestAccAWSRedshiftSecurityGroup_updateIngressCidr
=== RUN   TestAccAWSRedshiftSecurityGroup_ingressSecurityGroup
=== PAUSE TestAccAWSRedshiftSecurityGroup_ingressSecurityGroup
=== RUN   TestAccAWSRedshiftSecurityGroup_updateIngressSecurityGroup
=== PAUSE TestAccAWSRedshiftSecurityGroup_updateIngressSecurityGroup
=== CONT  TestAccAWSRedshiftSecurityGroup_basic
=== CONT  TestAccAWSRedshiftSecurityGroup_updateIngressSecurityGroup
=== CONT  TestAccAWSRedshiftSecurityGroup_ingressCidr
=== CONT  TestAccAWSRedshiftSecurityGroup_updateIngressCidr
=== CONT  TestAccAWSRedshiftSecurityGroup_ingressSecurityGroup
--- PASS: TestAccAWSRedshiftSecurityGroup_ingressCidr (25.88s)
--- PASS: TestAccAWSRedshiftSecurityGroup_basic (26.38s)
--- PASS: TestAccAWSRedshiftSecurityGroup_ingressSecurityGroup (32.05s)
--- PASS: TestAccAWSRedshiftSecurityGroup_updateIngressCidr (59.55s)
--- PASS: TestAccAWSRedshiftSecurityGroup_updateIngressSecurityGroup (67.93s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       68.932s

[bflad]

TeamCity acceptance testing is not happy with the new import test steps for the non-basic tests since they do not have test/Terraform configuration to inform them to run in us-east-1:

--- FAIL: TestAccAWSRedshiftSecurityGroup_ingressCidr (13.78s)
    testing.go:569: Step 1 error: Error retrieving Redshift Security Groups: InvalidParameterValue: VPC-by-Default customers cannot use cluster security groups
--- FAIL: TestAccAWSRedshiftSecurityGroup_ingressSecurityGroup (16.38s)
    testing.go:569: Step 1 error: Error retrieving Redshift Security Groups: InvalidParameterValue: VPC-by-Default customers cannot use cluster security groups
--- FAIL: TestAccAWSRedshiftSecurityGroup_updateIngressCidr (16.13s)
    testing.go:569: Step 1 error: Error retrieving Redshift Security Groups: InvalidParameterValue: VPC-by-Default customers cannot use cluster security groups
--- FAIL: TestAccAWSRedshiftSecurityGroup_updateIngressSecurityGroup (19.71s)
    testing.go:569: Step 1 error: Error retrieving Redshift Security Groups: InvalidParameterValue: VPC-by-Default customers cannot use cluster security groups

My recommendations would be to either add the Config of the previous step to each of these new import test steps or remove the hardcoded provider "aws" configurations and copy the AWS_DEFAULT_REGION environment variable handling from the basic test to the others for consistency. 👍

[bflad]

LGTM 🚀

--- PASS: TestAccAWSRedshiftParameterGroup_basic (10.59s)
--- PASS: TestAccAWSRedshiftParameterGroup_withoutParameters (11.26s)
--- PASS: TestAccAWSRedshiftParameterGroup_withParameters (10.74s)
--- PASS: TestAccAWSRedshiftParameterGroup_withTags (21.62s)

--- PASS: TestAccAWSRedshiftSecurityGroup_basic (8.51s)
--- PASS: TestAccAWSRedshiftSecurityGroup_ingressCidr (8.78s)
--- PASS: TestAccAWSRedshiftSecurityGroup_ingressSecurityGroup (9.87s)
--- PASS: TestAccAWSRedshiftSecurityGroup_updateIngressCidr (17.49s)
--- PASS: TestAccAWSRedshiftSecurityGroup_updateIngressSecurityGroup (20.32s)

--- PASS: TestAccAWSRedshiftSubnetGroup_basic (14.06s)
--- PASS: TestAccAWSRedshiftSubnetGroup_tags (20.00s)
--- PASS: TestAccAWSRedshiftSubnetGroup_updateDescription (20.47s)
--- PASS: TestAccAWSRedshiftSubnetGroup_updateSubnetIds (21.29s)

[ghost]

This has been released in version 2.30.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!